-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card examples fix #1376
Card examples fix #1376
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
Design review done. Some missing callouts that will be added with #1614 (comment) but will be added with #1199. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A migration guide note should be added to talk about changes happening in the Cards component page and in the Cards example page; change of <h*>
HTML tags, bold usage in which case, <button>
s instead of <a>
s, size of images, etc.
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat!
Fixes #1327
Here is one solution to better fit design on documentation. I think that this solution is the best regarding the others I had. I'm open to discussion if you think that it would be better in another way 😄