Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new behavior of pa11y-ci 3.1.0 #2386

Closed
3 tasks done
julien-deramond opened this issue Nov 23, 2023 · 1 comment
Closed
3 tasks done

Fix new behavior of pa11y-ci 3.1.0 #2386

julien-deramond opened this issue Nov 23, 2023 · 1 comment

Comments

@julien-deramond
Copy link
Contributor

julien-deramond commented Nov 23, 2023

Prerequisites

Describe the issue

Since pa11y-ci has been bumped from 3.0.2 to 3.1.0, the accessibility job fails (see https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/actions/runs/6969221673/job/18964696038?pr=2385).

This is probably due to the peer dependency that makes also a bump from pa11y ~6.1.0 to ^6.2.3 (to analyze).

It can be reproduced locally too by running:

$ npm ci
$ npm run dist
$ npm run release-sri
$ npm run docs-build
$ npm run docs-accessibility

Errors in http://localhost:9001/docs/5.3/forms/checks-radios/:

 • ARIA hidden element must not contain focusable elements
   (https://dequeuniversity.com/rules/axe/4.2/aria-hidden-focus?application=axeAPI)

   (html > body > div:nth-child(6) > main > div:nth-child(3) >
   div:nth-child(65) > div:nth-child(1) > form > fieldset)

   <fieldset class="star-rating" disabled="" aria-hidden="true"> <legend
   class="visually-hi...</fieldset>

✘ 131/132 URLs passed
ERROR: "docs-pa11y" exited with 2.
Error: Process completed with exit code 1.

The aim of this issue is to fix either the use case or to tell pa11y not to scan the use cases (by modifying .pa11y-ci.json) which corresponds to https://boosted.netlify.app/docs/5.3/forms/checks-radios/#disabled-2.

Note: 888db1e hid temporarily this use case to continue working on the dark mode: fieldset.star-rating[disabled].

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Chrome, Firefox

What version of Boosted are you using?

main (v5.3.3)

@julien-deramond
Copy link
Contributor Author

Answered in #2399 (comment), it is an error from pa11y and not something to fix. So I'll close this issue and update https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/wiki/Docs-accessibility-issues accordingly.

@julien-deramond julien-deramond closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant