Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tabindex="0" whenever .overflow-*-{auto|scroll} are used for a11y #2179

Open
julien-deramond opened this issue Jul 27, 2023 · 0 comments
Open

Add tabindex="0" whenever .overflow-*-{auto|scroll} are used for a11y #2179

julien-deramond opened this issue Jul 27, 2023 · 0 comments
Labels
accessibility bootstrap-side Things to implement in Bootstrap first enhancement on hold

Comments

@julien-deramond
Copy link
Contributor

julien-deramond commented Jul 27, 2023 •
edited
Loading

In #2162, axe-core dep has been bumped after regeneration of our package-lock.json, leading to changes in pa11y results.

More information at #2162 (comment).

One of the new errors caught by pa11y is that we should add tabindex="0" whenever .overflow-*-{auto|scroll}s are used for a11y reasons.

A fix has been proposed upstream via twbs/bootstrap#38963.

⚠️ This issue is on hold until we have feedback from the upstream PR.

When this issue will be fixed, don't forget to remove .overflow-y-scroll, .overflow-y-auto, .overflow-x-scroll, .overflow-x-auto rules from .pa11yci.json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility bootstrap-side Things to implement in Bootstrap first enhancement on hold
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@julien-deramond