Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[account_mtd] Make redirect url tolerant of trailing / appended by user #57

Open
1 of 4 tasks
Nick-OpusVL opened this issue Jul 5, 2019 · 1 comment
Open
1 of 4 tasks

[account_mtd] Make redirect url tolerant of trailing / appended by user #57

Nick-OpusVL opened this issue Jul 5, 2019 · 1 comment

Comments

@Nick-OpusVL
Copy link
Contributor

Nick-OpusVL commented Jul 5, 2019 •
edited
Loading

mtd_user_authorisation.py

Line that needs to change:

        redirect_uri = "{}/auth-redirect".format(record.hmrc_configuration.redirect_url)

Target branches (this can be closed once a fix has been merged into all of them):

  • mtd-vat-8.0
  • mtd-vat-10.0
  • mtd-vat-11.0
  • mtd-vat-12.0
@Nick-OpusVL Nick-OpusVL changed the title [account_mtd] Make redirect url tolerant of trailing / [account_mtd] Make redirect url tolerant of trailing / appended by user Jul 5, 2019
Nick-OpusVL added a commit that referenced this issue Jul 8, 2019
@Nick-OpusVL
[#57] Make redirect URL field tolerant of trailing / appended by user
02f6b4b
Nick-OpusVL added a commit that referenced this issue Jul 8, 2019
@Nick-OpusVL
[#57] Make redirect URL field tolerant of trailing / appended by user
ffe136f
Nick-OpusVL added a commit that referenced this issue Jul 8, 2019
@Nick-OpusVL
[8.0][#57] Make MTD authorisation tolerant of trailing / on redirec…
c6e452a 
…t URL configured by user

Merge pull request #59 from OpusVL/mtd-vat-8.0-57-tolerate-trailing-slash-on-redirect-url
@Nick-OpusVL
Copy link
Contributor Author

Fixed in mtd-vat-8.0. Kept open because it may need porting to other versions too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nick-OpusVL