Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #6 and #8 once Node.js download is fixed #7

Closed
mtneug opened this issue Aug 20, 2024 · 3 comments
Closed

Revert #6 and #8 once Node.js download is fixed #7

mtneug opened this issue Aug 20, 2024 · 3 comments

Comments

@mtneug
Copy link
Member

mtneug commented Aug 20, 2024 •
edited
Loading

This is to keep track of reverting #6 and #8 once upstream changes were made.
ferishili added a commit that referenced this issue Aug 20, 2024
@ferishili
Force nvm v0.39 also for test tasks
92c3ce6 
This is complementary to #6 and refs #7 to revert
@ferishili ferishili mentioned this issue Aug 20, 2024
Merged
@mtneug mtneug changed the title Revert #6 once Node.js download is fixed Revert #6 and #8 once Node.js download is fixed Aug 20, 2024
@abias
Copy link
Member

abias commented Oct 30, 2024

Just a heads-up for you:
The upstream changes are there, you can revert these workarounds now @mtneug @ferishili

@ferishili
Copy link
Contributor

Hi everyone,
FYI: I am going to start reverting the PRs
Maybe @bluetom should also be notified about this!
BR

@ferishili
Copy link
Contributor

Close as completed in #9 and #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abias @mtneug @ferishili