Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BLE curtain mode #908

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Fix BLE curtain mode #908

merged 2 commits into from
Feb 4, 2024

Conversation

dnicolson
Copy link
Collaborator

♻️ Current situation

If the curtain mode was not defined in the settings the following error would occur:

Curtain: Curtain failed BLEpushChanges with BLE Connection, Error Message: "The type of running mode is incorrect: object"

💡 Proposed solution

  • Set position mode to strings
  • Remove redundant code
  • Set proper values for node-switchbot

@donavanbecker
Copy link
Collaborator

please rebase with beta branch

@dnicolson dnicolson changed the base branch from latest to beta-3.1.1 February 4, 2024 15:49
@github-actions github-actions bot added enhancement New feature or request beta labels Feb 4, 2024
@donavanbecker donavanbecker merged commit 1071eea into OpenWonderLabs:beta-3.1.1 Feb 4, 2024
4 checks passed
@donavanbecker donavanbecker mentioned this pull request Feb 5, 2024
donavanbecker added a commit that referenced this pull request Feb 5, 2024
## [3.1.1](https://github.com/OpenWonderLabs/homebridge-switchbot/releases/tag/v3.1.1) (2024-02-05)

### What's Changed
- Fix BLE connection [#907](#907), Thanks [@dnicolson](https://github.com/dnicolson)
- Fix BLE curtain mode [#908](#908), Thanks [@dnicolson](https://github.com/dnicolson)
- Fix curtain characteristic warning [#909](#909), Thanks [@dnicolson](https://github.com/dnicolson)
- Revert curtain retry functionality [#911](#911), Thanks [@dnicolson](https://github.com/dnicolson)
- Code Cleaup [#910](#910) [#912](#912) [#913](#913)  [#917](#917), Thanks [@dnicolson](https://github.com/dnicolson)
- Housekeeping and updated dependencies.

**Full Changelog**: v3.1.0...v3.1.1
donavanbecker added a commit that referenced this pull request Feb 5, 2024
## [3.1.1](https://github.com/OpenWonderLabs/homebridge-switchbot/releases/tag/v3.1.1) (2024-02-05)

### What's Changed
- Fix BLE connection [#907](#907), Thanks [@dnicolson](https://github.com/dnicolson)
- Fix BLE curtain mode [#908](#908), Thanks [@dnicolson](https://github.com/dnicolson)
- Fix curtain characteristic warning [#909](#909), Thanks [@dnicolson](https://github.com/dnicolson)
- Revert curtain retry functionality [#911](#911), Thanks [@dnicolson](https://github.com/dnicolson)
- Code Cleaup [#910](#910) [#912](#912) [#913](#913)  [#917](#917), Thanks [@dnicolson](https://github.com/dnicolson)
- Housekeeping and updated dependencies.

**Full Changelog**: v3.1.0...v3.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants