-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.0 #1070
Merged
Merged
v4.0.0 #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## ♻️ Current situation The Contact Sensor has three states: `open`, `close`, and `timeOutNotClose`[^1]. `timeOutNotClose` indicating that the door/window has been open for an extended period. However, in the current implementation, the `timeOutNotClose` state is not handled correctly, causing the state to be incorrectly updated to `close`. ## 💡 Proposed solution I modified the handling so that `timeOutNotClose` behaves the same as `open` state, and I created a private function for shared handling to prevent future bugs. ## ⚙️ Release Notes - Fix incorrect handling of openState in Contact Sensor ## ➕ Additional Information ### Testing ### Reviewer Nudging [^1]: https://github.com/OpenWonderLabs/SwitchBotAPI/tree/main?tab=readme-ov-file#contact-sensor-1 Co-authored-by: Donavan Becker <[email protected]>
fix light level report, which was stuck at max due to the inappropriate assignment operator. ## ♻️ Current situation See #1065 - ambient light level reported to HomeKit is stuck at 6000 lux despite light level report being accurate. Debugging revealed an accidental assignment operator ("=") where a comparison ("===") was required. ## 💡 Proposed solution This PR contains a one-line patch to fix the above. ## ⚙️ Release Notes No change required. ### Testing Not aware of any relevant tests ### Reviewer Nudging Observe the ambient light level of a connected hub 2 in home bridge UI before and after the patch.
## [4.0.0](https://github.com/OpenWonderLabs/homebridge-switchbot/releases/tag/v4.0.0) (2024-10-11) ### What's Changed ####⚠️ Breaking Changes - Added `deviceType` based config - This allows you to set a setting that will be used across the same deviceType - `deviceType` based config settings can be over written by individual device settings set by the deviceId - Added `remoteType` based config - This allows you to set a setting that will be used across the same IR remoteType - `remoteType` based config settings can be over written by individual device settings set by the deviceId - All device specific configs have been moved to the same level on the config to elimate the use of multiple of the same config and to better support the new `deviceType` based config. - **⚠️ If you have config set for any of the following SwitchBot device Types: `Curtain`, `Blind Tilt`, `Color Bulb`, `Strip Light`, `Hub`, `Meter`, `Meter Plus`, `Humidifier`, `Contact Sensor`, `Motion Sensor`, `Water Detector`, `Ceiling Light`, or `Lock`; you will need to re-setup your config for that deviceId** - **⚠️ If you have config set for any of the following IR remote Types: `Fan`, `DIY Fan`, `Light`, `DIY Light`, `Air Conditioner`, `DIY Air Conditioner`, or `Others`; you will need to re-setup your config for that deviceId** - OpenAPI is now support by Version [3.0.0](https://github.com/OpenWonderLabs/node-switchbot/releases/latest) of [`node-switchbot`](https://github.com/OpenWonderLabs/node-switchbot), so made changes to refect that. #### Other Changes - Add `K10+ Pro` deviceType Support - Housekeeping and updated dependencies. **Full Changelog**: v3.8.3...v4.0.0
github-actions
bot
added
enhancement
New feature or request
dependencies
Pull requests that update a dependency file
workflow
docs
latest
labels
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
docs
enhancement
New feature or request
latest
major
major release change
workflow
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.0.0 (2024-10-11)
What's Changed
deviceType
based configdeviceType
based config settings can be over written by individual device settings set by the deviceIdremoteType
based configremoteType
based config settings can be over written by individual device settings set by the deviceIddeviceType
based config.Curtain
,Blind Tilt
,Color Bulb
,Strip Light
,Hub
,Meter
,Meter Plus
,Humidifier
,Contact Sensor
,Motion Sensor
,Water Detector
,Ceiling Light
, orLock
; you will need to re-setup your config for that deviceId**Fan
,DIY Fan
,Light
,DIY Light
,Air Conditioner
,DIY Air Conditioner
, orOthers
; you will need to re-setup your config for that deviceId**node-switchbot
, so made changes to refect that.Other Changes
K10+ Pro
deviceType SupportFull Changelog: v3.8.3...v4.0.0