Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is Madonna's real name question fails #3

Open
adocampo opened this issue Jan 19, 2021 · 11 comments
Open

What is Madonna's real name question fails #3

adocampo opened this issue Jan 19, 2021 · 11 comments

Comments

@adocampo
Copy link

I don't know if this is related to #2 but when you ask for someone's name, it says the device's name instead
imagen
@goldyfruit
Copy link
Member

I got an issue with the same utterance:

[nltk_data] Downloading package punkt to /home/ovos/nltk_data...
[nltk_data]   Package punkt is already up-to-date!
[nltk_data] Downloading package averaged_perceptron_tagger to
[nltk_data]     /home/ovos/nltk_data...
[nltk_data]   Package averaged_perceptron_tagger is already up-to-
[nltk_data]       date!
[nltk_data] Downloading package universal_tagset to
[nltk_data]     /home/ovos/nltk_data...
[nltk_data]   Package universal_tagset is already up-to-date!
2023-08-22 10:54:53.264 - skills - ovos_core.transformers:transform:63 - DEBUG - ovos-utterance-coref-normalizer: {'client_name': 'mycroft_cli', 'source': 'debug_cli', 'destination': ['skills'], 'session': {'active_skills': [], 'utterance_states': {}, 'session_id': 'daa55d18-bc4a-421d-ad3f-8fdec18affe6', 'history': [[{'type': 'recognizer_loop:utterance', 'data': {'utterances': ["What's 18 times 4?"], 'lang': 'en-us'}, 'context': {}}, 1692716034.0595658], [{'type': 'recognizer_loop:utterance', 'data': {'utterances': ["What is Madonna's real name?"], 'lang': 'en-us'}, 'context': {}}, 1692716050.4036782], [{'type': 'recognizer_loop:utterance', 'data': {'utterances': ["What is Madonna's real name?"], 'lang': 'en-us'}, 'context': {}}, 1692716093.259147]], 'lang': 'en-us', 'valid_languages': ['en-us'], 'context': {'timeout': 101560228980, 'frame_stack': []}}, 'lang': 'en-us'}
2023-08-22 10:54:53.265 - skills - ovos_core.transformers:transform:63 - DEBUG - ovos-utterance-normalizer: {'client_name': 'mycroft_cli', 'source': 'debug_cli', 'destination': ['skills'], 'session': {'active_skills': [], 'utterance_states': {}, 'session_id': 'daa55d18-bc4a-421d-ad3f-8fdec18affe6', 'history': [[{'type': 'recognizer_loop:utterance', 'data': {'utterances': ["What's 18 times 4?"], 'lang': 'en-us'}, 'context': {}}, 1692716034.0595658], [{'type': 'recognizer_loop:utterance', 'data': {'utterances': ["What is Madonna's real name?"], 'lang': 'en-us'}, 'context': {}}, 1692716050.4036782], [{'type': 'recognizer_loop:utterance', 'data': {'utterances': ["What is Madonna's real name?"], 'lang': 'en-us'}, 'context': {}}, 1692716093.259147]], 'lang': 'en-us', 'valid_languages': ['en-us'], 'context': {'timeout': 101560228980, 'frame_stack': []}}, 'lang': 'en-us'}
2023-08-22 10:54:53.266 - skills - ovos_core.intent_services:_handle_transformers:197 - DEBUG - utterances transformed: ["What is Madonna's real name?"] -> ["What is Madonna 's real name", "What is Madonna's real name"]
2023-08-22 10:54:53.269 - skills - ovos_core.intent_services.padatious_service:_match_level:50 - DEBUG - Padatious Matching confidence > 0.95
2023-08-22 10:54:53.272 - skills - ovos_core.intent_services.commonqa_service:handle_question:123 - INFO - Searching for What is Madonna 's real name
2023-08-22 10:54:58.340 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:178 - INFO - Timeout occurred check responses
2023-08-22 10:54:58.476 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:172 - WARNING - got a common query response outside search window
2023-08-22 10:54:58.476 - skills - ovos_core.intent_services.fallback_service:_fallback_range:171 - DEBUG - checking for FallbackSkillsV1
2023-08-22 10:54:58.480 - skills - ovos_workshop.skills.fallback:handler:121 - DEBUG - Checking fallbacks in range 0 - 5
2023-08-22 10:54:58.525 - skills - ovos_core.intent_services.padatious_service:_match_level:50 - DEBUG - Padatious Matching confidence > 0.8
2023-08-22 10:54:58.525 - skills - ovos_core.intent_services.fallback_service:_fallback_range:171 - DEBUG - checking for FallbackSkillsV1
2023-08-22 10:54:58.529 - skills - ovos_workshop.skills.fallback:handler:121 - DEBUG - Checking fallbacks in range 5 - 90
2023-08-22 10:54:58.573 - skills - ovos_core.intent_services.padatious_service:_match_level:50 - DEBUG - Padatious Matching confidence > 0.5
2023-08-22 10:54:58.574 - skills - ovos_core.intent_services.fallback_service:_fallback_range:171 - DEBUG - checking for FallbackSkillsV1
2023-08-22 10:54:58.577 - skills - ovos_workshop.skills.fallback:handler:121 - DEBUG - Checking fallbacks in range 90 - 101
2023-08-22 10:54:58.622 - skills - ovos_core.intent_services:handle_utterance:312 - DEBUG - intent matching took: 5.3537232875823975
2023-08-22 10:54:58.624 - skills - ovos_utils.file_utils:resolve_resource_file:153 - WARNING - Deprecation version=0.1.0. Caller=ovos_utils.sound:93. Expected a dict config and got None.
High Performance MPEG 1.0/2.0/2.5 Audio Player for Layers 1, 2 and 3
	version 1.31.2; written and copyright by Michael Hipp and others
	free software (LGPL) without any warranty but with best wishes

Directory: /home/ovos/.venv/lib/python3.11/site-packages/mycroft/res/snd/
Playing MPEG stream 1 of 1: error.mp3 ...

MPEG 1.0 L III cbr64 44100 j-s

	Title:   multimedia error 03 sound effect
	Artist:  freesoundeffect.net
	Album:   freesoundeffect.net
	Year:    2016
	Genre:   Rock
	Comment: excellent!



[0:01] Decoding of error.mp3 finished.

But when removing 's its working.

[nltk_data] Downloading package punkt to /home/ovos/nltk_data...
[nltk_data]   Package punkt is already up-to-date!
[nltk_data] Downloading package averaged_perceptron_tagger to
[nltk_data]     /home/ovos/nltk_data...
[nltk_data]   Package averaged_perceptron_tagger is already up-to-
[nltk_data]       date!
[nltk_data] Downloading package universal_tagset to
[nltk_data]     /home/ovos/nltk_data...
[nltk_data]   Package universal_tagset is already up-to-date!
2023-08-22 10:55:52.840 - skills - ovos_core.transformers:transform:63 - DEBUG - ovos-utterance-coref-normalizer: {'client_name': 'mycroft_cli', 'source': 'debug_cli', 'destination': ['skills'], 'session': {'active_skills': [], 'utterance_states': {}, 'session_id': 'daa55d18-bc4a-421d-ad3f-8fdec18affe6', 'history': [[{'type': 'recognizer_loop:utterance', 'data': {'utterances': ["What's 18 times 4?"], 'lang': 'en-us'}, 'context': {}}, 1692716034.0595658], [{'type': 'recognizer_loop:utterance', 'data': {'utterances': ["What is Madonna's real name?"], 'lang': 'en-us'}, 'context': {}}, 1692716050.4036782], [{'type': 'recognizer_loop:utterance', 'data': {'utterances': ["What is Madonna's real name?"], 'lang': 'en-us'}, 'context': {}}, 1692716093.259147], [{'type': 'recognizer_loop:utterance', 'data': {'utterances': ['What is Madonna real name?'], 'lang': 'en-us'}, 'context': {}}, 1692716152.8344364]], 'lang': 'en-us', 'valid_languages': ['en-us'], 'context': {'timeout': 101560228980, 'frame_stack': []}}, 'lang': 'en-us'}
2023-08-22 10:55:52.841 - skills - ovos_core.transformers:transform:63 - DEBUG - ovos-utterance-normalizer: {'client_name': 'mycroft_cli', 'source': 'debug_cli', 'destination': ['skills'], 'session': {'active_skills': [], 'utterance_states': {}, 'session_id': 'daa55d18-bc4a-421d-ad3f-8fdec18affe6', 'history': [[{'type': 'recognizer_loop:utterance', 'data': {'utterances': ["What's 18 times 4?"], 'lang': 'en-us'}, 'context': {}}, 1692716034.0595658], [{'type': 'recognizer_loop:utterance', 'data': {'utterances': ["What is Madonna's real name?"], 'lang': 'en-us'}, 'context': {}}, 1692716050.4036782], [{'type': 'recognizer_loop:utterance', 'data': {'utterances': ["What is Madonna's real name?"], 'lang': 'en-us'}, 'context': {}}, 1692716093.259147], [{'type': 'recognizer_loop:utterance', 'data': {'utterances': ['What is Madonna real name?'], 'lang': 'en-us'}, 'context': {}}, 1692716152.8344364]], 'lang': 'en-us', 'valid_languages': ['en-us'], 'context': {'timeout': 101560228980, 'frame_stack': []}}, 'lang': 'en-us'}
2023-08-22 10:55:52.841 - skills - ovos_core.intent_services:_handle_transformers:197 - DEBUG - utterances transformed: ['What is Madonna real name?'] -> ['What is Madonna real name']
2023-08-22 10:55:52.843 - skills - ovos_core.intent_services.padatious_service:_match_level:50 - DEBUG - Padatious Matching confidence > 0.95
2023-08-22 10:55:52.847 - skills - ovos_core.intent_services.commonqa_service:handle_question:123 - INFO - Searching for What is Madonna real name
2023-08-22 10:55:56.481 - skills - ovos_core.intent_services.commonqa_service:handle_query_response:156 - INFO - Answer from skill-ovos-wolfie.openvoiceos
2023-08-22 10:55:56.482 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:178 - INFO - Timeout occurred check responses
2023-08-22 10:55:56.483 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:202 - INFO - Handling with: skill-ovos-wolfie.openvoiceos
2023-08-22 10:55:56.649 - skills - ovos_core.intent_services.commonqa_service:_query_timeout:172 - WARNING - got a common query response outside search window
2023-08-22 10:55:56.650 - skills - ovos_core.intent_services:handle_utterance:312 - DEBUG - intent matching took: 3.8069498538970947

@ChanceNCounter
Copy link

The OP is an overcapture by an Adapt skill, which went stale because there’s no obvious solution. The complete failure looks like a tokenizer bug; I’m on a phone, but try it without the apostrophe

@goldyfruit
Copy link
Member

Yep, this is what I did (second part of the message).

@JarbasAl
Copy link
Member

not quite the tokenizer fault, as common query skills are meant to handle raw utterances...

i'm surprised wolfram alpha api bugs out in that case

@ChanceNCounter
Copy link

Sorry, I meant, remove just the apostrophe. What is Madonnas real name

I expect the intent parsers to see what is madonnas real name or less, and I’m getting the impression that’s not what it’s getting from this input

@ChanceNCounter
Copy link

not quite the tokenizer fault, as common query skills are meant to handle raw utterances

I was thinking it should still overcapture, but I now realize it’s possible Goldy just doesn’t have the personality skill installed (rather than it missing)

@JarbasAl
Copy link
Member

JarbasAl commented Aug 22, 2023 •
edited
Loading

Sorry, I meant, remove just the apostrophe. What is Madonnas real name

I expect the intent parsers to see what is madonnas real name or less, and I’m getting the impression that’s not what it’s getting from this input

according to logs the skill is getting the possible transcriptions ["What is Madonna 's real name", "What is Madonna's real name"] , but only first one is considered by the skill

I guess we should make this skill always use the original utterance and not the normalized version

@ChanceNCounter
Copy link

according to logs the skill is getting the possible transcriptions ["What is Madonna 's real name", "What is Madonna's real name"]

the point I don’t think I’m getting across is that our pipeline may be farting on the apostrophe, which will almost always come from directly input text rather than STT

@mikejgray
Copy link
Contributor

according to logs the skill is getting the possible transcriptions ["What is Madonna 's real name", "What is Madonna's real name"]

the point I don’t think I’m getting across is that our pipeline may be farting on the apostrophe, which will almost always come from directly input text rather than STT

Why would it not come from STT? Something strips it out? Whisper delivers plenty of punctuation.

@JarbasAl
Copy link
Member

the transcription alternatives usually are a normalized_utt + raw utt, depending on utterance plugins there might be more normalizations (such as coreference resolution)

all utts are then send to common query here https://github.com/OpenVoiceOS/ovos-core/blob/dev/ovos_core/intent_services/commonqa_service.py#L101

this issue seems to be wolfram alpha api specific, the utterances are not mangled as seen in logs

@builderjer
Copy link
Member

I have seen the apostrophe issue before on other skills also

play 80's music does not work with voice, but will with typing it in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@goldyfruit @adocampo @ChanceNCounter @mikejgray @JarbasAl @builderjer