Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure appropriate format for translators #12

Open
emphasize opened this issue Apr 30, 2023 · 0 comments
Open

Ensure appropriate format for translators #12

emphasize opened this issue Apr 30, 2023 · 0 comments

Comments

@emphasize
Copy link
Member

This is a general issue, translators can't handle input like:

sentence\nsentence\nsentence

The result is a mix and match of english and the language translated from/to

2023-04-30 21:17:57.787 - OVOS - ovos_plugin_manager.language:create:131 - INFO - Loaded the Language Translation plugin deepl_translate_plug
2023-04-30 21:17:59.327 - OVOS - ovos_translate_plugin_deepl:translate:93 - DEBUG - Translation (DE->EN-US): who is Karl Koch
2023-04-30 21:18:00.880 - OVOS - ovos_translate_plugin_deepl:translate:93 - DEBUG - Translation (EN->DE): Grundlegende Informationen
2023-04-30 21:18:01.188 - OVOS - ovos_translate_plugin_deepl:translate:93 - DEBUG - Translation (EN->DE): Grundlegende Informationen.
Geburtsdatum | Freitag, März 19, 1920 (vor 103 Jahren)
date of death | Saturday, July 29, 1944 (age: 24 years) (vor 78 Jahren)
2023-04-30 21:18:01.433 - OVOS - ovos_translate_plugin_deepl:translate:93 - DEBUG - Translation (EN->DE): Zeitleiste
2023-04-30 21:18:01.686 - OVOS - ovos_translate_plugin_deepl:translate:93 - DEBUG - Translation (EN->DE): https://www6b3.wolframalpha.com/Calculate/MSP/MSP59751d24bd5h36i2246300003c49bf5g9abcf3c2?MSPStoreType=image/gif&s=19
{'title': 'Grundlegende Informationen', 'summary': 'Grundlegende Informationen.\nGeburtsdatum | Freitag, März 19, 1920 (vor 103 Jahren)\ndate of death | Saturday, July 29, 1944 (age: 24 years) (vor 78 Jahren)'}
{'title': 'Zeitleiste', 'img': 'https://www6b3.wolframalpha.com/Calculate/MSP/MSP59751d24bd5h36i2246300003c49bf5g9abcf3c2?MSPStoreType=image/gif&s=19'}

furthermore we should carefully select what to translate. In this case data["img"] doesn't need a translation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant