Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Skills failing to load due to issues in setup.py do not log exceptions #216

Open
mikejgray opened this issue Mar 10, 2024 · 1 comment

Comments

@mikejgray
Copy link
Contributor

When developing skills and experimenting with different packaging, or with the projen skill generator, sometimes I'll make changes to setup.py to test something and fail. When this happens my skill fails to load but doesn't give me anything in the OVOS logs as to why. I do get those logs when I pop a REPL and instantiate my skill class (or do it in my IDE).

This leads to a poor developer experience, as it's not intuitive at all for someone unfamiliar with how OVOS handles skill loading. Acceptance criteria would be logging those exceptions in OVOS when a skill fails to load properly.

[JarbasAI]
LOG.exception will print them
probably somewhere in the loading of skills isnt doing this and should

@mikejgray
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant