-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PnPTimeout handling #31
Comments
If using https://usbguard.github.io/ or similar, and the device is unauthorized by default, the first attempt to open the device will typically fail. However, the whitelisting would likely happen fast. So perhaps doing the first retry of failed open attempt fairly soon (after 100ms or so) would be helpful. The following retries could be increased incrementally/exponentially, or just have two timeouts (first fast one, and second longer one). |
Probably, I've used DNSSdRetryInterval instead of DevInitRetryInterval by mistake. Fixed. Regarding using small timeout for the first initialization attempt, I can implement it, but I'm not sure if it really needed. Existent code only delays printer initialization for a couple of seconds; printer is a "big thing", and I don't think somebody expects it to be available in a few milliseconds after connected. What do you think? |
I mentioned it, because for me it was observable performance degradation when going from
Given the whole chain there was several seconds more delay from printer plugin to becoming visible in UI. So I figured the 2s retry was first easy target to improve things a bit. |
Then again, seems this is not too huge issue, and I can just adjust the |
You are also almost convinced me to implement exponential bake-off, starting from some small value. |
const.go
definesDevInitRetryInterval
but it is never used. I assumepnp.go
:PnPStart
andpnpRetryTime
should be using it instead ofDNSSdRetryInterval
.The text was updated successfully, but these errors were encountered: