Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cupsctl removes comments and empty lines from cupsd.conf #408

Open
zdohnal opened this issue May 31, 2022 · 3 comments
Open

cupsctl removes comments and empty lines from cupsd.conf #408

zdohnal opened this issue May 31, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request priority-low
Milestone

Comments

@zdohnal
Copy link
Member

zdohnal commented May 31, 2022

When user calls cupsctl, f.e. cupsctl --remote-any or cupsctl --debug-logging, almost all comments and empty lines removed. Probably ignoring empty lines could be fine, but removing comments IMHO reduces readability.

@zdohnal zdohnal added bug Something isn't working priority-low labels May 31, 2022
@zdohnal zdohnal added this to the v2.4.3 milestone May 31, 2022
@zdohnal zdohnal self-assigned this May 31, 2022
@jsmeix
Copy link

jsmeix commented May 31, 2022

By the way:
This is the reason why I personally never use cupsctl.
Strictly speaking this is even a critical bug because
user data (user comments in config files are user data)
has to be sacrosanct - always.
As far as I know cupsd.conf is still also meant for users
to manually specify their settings (when cupsd is not running).

@michaelrsweet
Copy link
Member

FWIW, the reason its been implemented this way for so many years is to avoid having the comments get out of sync - for example (from the stock cupsd.conf file):

# Log general information in error_log - change "warn" to "debug"
# for troubleshooting...
LogLevel warn

Also, If you do decide to preserve comments, don't add new ones... :)

@michaelrsweet michaelrsweet modified the milestones: v2.4.3, v2.4.4 Jun 2, 2023
@zdohnal zdohnal modified the milestones: v2.4.4, v2.4.x Jun 14, 2023
@michaelrsweet michaelrsweet modified the milestones: v2.4.x, v2.5 Apr 5, 2024
@michaelrsweet michaelrsweet added enhancement New feature or request and removed bug Something isn't working labels Apr 5, 2024
@michaelrsweet
Copy link
Member

I'm pushing this to CUPS 2.5 because this isn't something we should try fixing in a patch update.

@michaelrsweet michaelrsweet modified the milestones: v2.5, Future Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-low
Projects
None yet
Development

No branches or pull requests

3 participants