Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC00158]: revamp webfonts + font-families attribution #402

Open
7 tasks done
Lungsangg opened this issue Oct 16, 2024 · 1 comment
Open
7 tasks done

[RFC00158]: revamp webfonts + font-families attribution #402

Lungsangg opened this issue Oct 16, 2024 · 1 comment
Assignees

Comments

@Lungsangg
Copy link
Collaborator

Lungsangg commented Oct 16, 2024

current situation

the serif/ sans-serif attribution in Sefaria doesn't correspond to our needs for Tibetan. So there is nothing much but hacks that can be done in the current situation.

Solution

each language should be treated independently from the others so that no interference happens.
we should have the ability to set the size/font/color/etc. for each part of the website for each locale.

Implementation steps

Step 1 (Lungsang)

  • Reset the font groupings to its initial Sefaria state

Step 2 (Lungsang)

  • check in the card with the required sizes and fonts what needs to be modified
  • write documentations in wiki about existing grouping system wiki link
  • when applying different color and size for tibetan and english, there shouldnt be any changes on the other language.
    • Search a solution
    • write documentation wiki link
    • Implement the solution in code
      • Text page
      • Topics page
      • Community page
      • Profile page
      • Collection page
      • Account setting page
      • Registration page
      • Resources

These are the changes to check

Texts main page

main header: sans-serif 18px black
Image

search: serif 16pt
Image

description: serif 19pt
Image

ཡིག་མཛོད་ཀྱི་དཀར་ཆ་ལ་ལྟ།: 17pt
Image

categories: 24pt
Image

subcategory: 26px
Image

category description: serif 16px
Image

Text

category of text: 22px
Image

versions: 20px
Image

version title: serif 20px
Image

version history: sans-serif 14
Image

ཕབ་ལེན།: 20px
Image

Reader App

resources: sans-serif 18px
Image

menu items: serif 18px
Image

menu categories: sans-serif 16px
Image

Translation description: serif 20px
Image

search message: 18px
Image

buttons: serif 18px
Image

ལུང་འགོད་སའི་ཟིན་བྲིས་འདེམས།: 18px
Image

Topics

topics search: 16px
Image

ཀ་ཁ་: 26px
Image

New Sheet buttons: serif 16px
Image

Community

Join the conversation: serif 28px
Image

Bookmarks

History: sans-serif 18px
Image

date: sans-serif 14px
Image

Notifications

notification category: serif
Image

Profile menu

menu items: serif 17px
Image

logout: serif 17px
Image

Profile

buttons: 18px
Image

Sheets-collections-comments menu: 20px
Image

@Lungsangg Lungsangg self-assigned this Oct 16, 2024
@Lungsangg Lungsangg converted this from a draft issue Oct 16, 2024
@Lungsangg Lungsangg changed the title RFC00159: revamp webfonts + font-families attribution RFC00158: revamp webfonts + font-families attribution Oct 18, 2024
@Lungsangg Lungsangg changed the title RFC00158: revamp webfonts + font-families attribution [RFC00158]: revamp webfonts + font-families attribution Oct 18, 2024
@Lungsangg Lungsangg moved this from IN PROGRESS to TO DO in Pecha.org Web Dev Nov 14, 2024
@kaldan007 kaldan007 moved this from TO DO to IN PROGRESS in Pecha.org Web Dev Nov 28, 2024
@drupchen drupchen moved this from IN PROGRESS to BLOCKED in Pecha.org Web Dev Dec 3, 2024
@drupchen drupchen moved this from BLOCKED to TO DO in Pecha.org Web Dev Dec 9, 2024
@Lungsangg Lungsangg moved this from TO DO to IN PROGRESS in Pecha.org Web Dev Dec 11, 2024
@Lungsangg Lungsangg moved this from IN PROGRESS to TO DO in Pecha.org Web Dev Dec 16, 2024
@lobsam lobsam moved this from TO DO to IN PROGRESS in Pecha.org Web Dev Dec 17, 2024
@ta4tsering ta4tsering moved this from IN PROGRESS to TESTING in Pecha.org Web Dev Dec 25, 2024
@ta4tsering ta4tsering assigned drupchen and unassigned Lungsangg Dec 25, 2024
@drupchen
Copy link

drupchen commented Jan 2, 2025

Font sizes don't correspond

@kaldan007 kaldan007 moved this from TESTING to IN PROGRESS in Pecha.org Web Dev Jan 3, 2025
@kaldan007 kaldan007 assigned Lungsangg and unassigned drupchen Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: IN PROGRESS
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants