Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC021:Revamp localization in pecha.org #301

Closed
15 tasks done
Lungsangg opened this issue Aug 28, 2024 · 2 comments
Closed
15 tasks done

RFC021:Revamp localization in pecha.org #301

Lungsangg opened this issue Aug 28, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Lungsangg
Copy link
Collaborator

Lungsangg commented Aug 28, 2024

solves RFW021

Description :

There are many strings in both react and django templates. They need to be extracted either in js or po file and apply unique identifier so that it can help integrate with tolgee as well as solve the issue of different meaning in Tibetan for one english string.

Implementation steps :

1. apply unique identifier to String js (js part)

  • Apply identifier key to each language string

  • Extract and apply identifier key to each hard coded string and

  • Apply context variable in language string

  • Import js file in tolgee

  • Integrate i18n with react js

2. apply unique identifier to Django template file

  • apply unique identifier to existing po file. (translator comment)

    • apply unique identifier to python module strings in po file (70)
  • find solution for extracting variable and string together

  • extract hardcoded strings and apply unique identifier (file by file)

    • number of strings in templates folder (55)
    • number of strings in templates/registration (16)
    • number of strings in templates/static (279)
  • apply unique identifier to the corresponding msgid

  • parse Translators comment as msgid, and msgid as msgstr

  • Import po file in tolgee

@Lungsangg Lungsangg converted this from a draft issue Aug 28, 2024
@Lungsangg Lungsangg added the enhancement New feature or request label Aug 28, 2024
@Lungsangg Lungsangg changed the title Apply unique identifier for all localization strings RFC021:Revamp localization in pecha.org Aug 28, 2024
@drupchen
Copy link

drupchen commented Sep 10, 2024

Resolve:

I propose that this hebrew string is searched in the whole codebase and popup removed.

Image

@drupchen la, this popup is generating in different place with different messages, if we disable it ..... the previous two have been localized and would be of no use so in my opinion should we localize the remaining strings ? so that later wherever sefaria have put in place the popup, only with Tibetan strings will appear.

if above suggestions is good, then below are the strings that need to translate in Tibetan.

Want to document a connection to another text?
Create a free account to do more on Pecha
Add interconnections & translations
Build & share source sheets
Get updates on new texts
Have your own translation of this text?
Create a free account to add it to the library & do more on Pecha
Build & share source sheets
Connect with other users
Want to connect with other Pecha users?
Create a free account to join the conversation
Follow your favorite creators
Build & share source sheets
Send messages
Want to return to this text?
Create a free account to do more on Pecha
View your reading history
Build & share source sheets
Make source sheets

@drupchen
Copy link

drupchen commented Sep 12, 2024

jennifer has a deadline on the 17th this month. She will meet HHDL office people for fundraising, but she needs a decent ZH localization. we should prioritize the main strings from Figma, push them on Tolgee so they can update the translations.

objective for this deadline: more or less the 500 strings from Figma here:
https://docs.google.com/spreadsheets/d/1URSkT231eXvJeRA4nWREgXiUks3nt9NcPIYbcDhpZII/edit?gid=0#gid=0

@kaldan007 kaldan007 moved this from IN PROGRESS to TESTING in Pecha.org Web Dev Sep 16, 2024
@kaldan007 kaldan007 moved this from TESTING to IN PROGRESS in Pecha.org Web Dev Sep 16, 2024
@kaldan007 kaldan007 moved this from IN PROGRESS to TESTING in Pecha.org Web Dev Sep 17, 2024
@kaldan007 kaldan007 assigned drupchen and unassigned lobsam and Lungsangg Sep 17, 2024
@kaldan007 kaldan007 moved this from TESTING to DONE in Pecha.org Web Dev Sep 23, 2024
@kaldan007 kaldan007 closed this as completed by moving to DONE in Pecha.org Web Dev Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: DONE
Development

No branches or pull requests

5 participants
@drupchen @kaldan007 @lobsam @Lungsangg and others