Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open for contribution #202

Open
shredderbvek opened this issue Mar 6, 2022 · 16 comments
Open

Open for contribution #202

shredderbvek opened this issue Mar 6, 2022 · 16 comments

Comments

@shredderbvek
Copy link

Volunteering for contribution as per the linkedin post by Prof. Alex Liberzon.

@alexlib
Copy link
Contributor

alexlib commented Mar 7, 2022

Hi @shredderbvek
thanks for writing.

Let's first follow the installation for developers instructions and see that you have a working version on your computer. Any issue or problem that raises during the installation - is great for us to learn and make the process simpler for the new developers. Please report the process, maybe as a short blog post or a wiki report.
Thanks
Alex
https://openptv-python.readthedocs.io/en/latest/developers.html

@alexlib
Copy link
Contributor

alexlib commented Mar 7, 2022

the first issue to resolve is to improve this documentation :)

https://github.com/openptv/docs/blob/master/docs/source/developers.txt

@prast367
Copy link

prast367 commented Mar 8, 2022

Hi Prof. Alex!

I am also in for volunteering as per your LinkedIn post.

Best regards,
Prakhar Rastogi

@alexlib
Copy link
Contributor

alexlib commented Mar 8, 2022

Great. @prast367 Let's follow the same path : installation for developers and documentation first.

We all work with forks - fork a software to your account and after changes ping us to test it and review it or send pull request
If these tasks are difficult - let us meet online to have a live demo.

@prast367
Copy link

Hi Prof. Alex!

Can I start by next week? Due to some health issues, I won't be able to start right now?

Best regards,

Prakhar

@alexlib
Copy link
Contributor

alexlib commented Mar 10, 2022

Hi Prof. Alex!

Can I start by next week? Due to some health issues, I won't be able to start right now?

Best regards,

Prakhar

everyone is free to work on his/her own pace.

@CleisonManriqueAguirre
Copy link
Contributor

CleisonManriqueAguirre commented Mar 14, 2022

Hi . Prof. Alex
I am a volunteering because of your LinkedIn post . Thanks for the opportunity. What is the first goal aside of installing Open PTV ?

@alexlib
Copy link
Contributor

alexlib commented Mar 14, 2022

Hi . Prof. Alex

I am a volunteering because of your LinkedIn post . Thanks for the opportunity. What is the first goal aside of installing Open PTV ?

Hi @C73150N great to see you. The first goal is to fix some bugs. In C or in Python. Another option is to write tests. See in py_bind

Whenever you are ready with the installed software, we can chat together and check which you like most

@CleisonManriqueAguirre
Copy link
Contributor

CleisonManriqueAguirre commented Mar 14, 2022

Hi . Prof. Alex

I am a volunteering because of your LinkedIn post . Thanks for the opportunity. What is the first goal aside of installing Open PTV ?

Hi @C73150N great to see you. The first goal is to fix some bugs. In C or in Python. Another option is to write tests. See in py_bind

Whenever you are ready with the installed software, we can chat together and check which you like most

Sure . I will let you notice . Do you recommend to use Windows or Ubuntu for better performing off OpenPTV ?

@alexlib
Copy link
Contributor

alexlib commented Mar 14, 2022 via email

@CleisonManriqueAguirre
Copy link
Contributor

Hi. I am having some issues while installing it but they seem to be solvable . Have you tried to install the C compiler through MSYS2 ? Or its not recommendable

@CleisonManriqueAguirre
Copy link
Contributor

CleisonManriqueAguirre commented Mar 15, 2022

Ubuntu is simpler. Windows if you must

Hi . I already installed OpenPTV and it all goes fine at the moment . Whats will be next ?

@alexlib
Copy link
Contributor

alexlib commented Mar 15, 2022

Ubuntu is simpler. Windows if you must

Hi . I already installed OpenPTV and it all goes fine at the moment . Whats will be next ?

  1. Please try to run the software according to the tutorial videos
    https://openptv-python.readthedocs.io/en/latest/tutorial.html
    you can use https://github.com/OpenPTV/test_cavity for comparing with the video

  2. Can you run the tests? There are two types of tests - C using libcheck library and Python, using pytest. We'd like to have all the tests which are presently in C - also in Python. for instance in python:

cd py_bind
python setup.py prepare
python setup.py install
cd tests
nose

should run 61 tests.

@CleisonManriqueAguirre
Copy link
Contributor

CleisonManriqueAguirre commented Mar 16, 2022

Sure I can . I will do step 1 first . Thanks . I forgot to mention that in the installation instruction there is missing some steps that I followed from google groups page specially the adding of pathdata.py file .

@CleisonManriqueAguirre
Copy link
Contributor

CleisonManriqueAguirre commented Mar 18, 2022

Ubuntu is simpler. Windows if you must

Hi . I already installed OpenPTV and it all goes fine at the moment . Whats will be next ?

  1. Please try to run the software according to the tutorial videos
    https://openptv-python.readthedocs.io/en/latest/tutorial.html
    you can use https://github.com/OpenPTV/test_cavity for comparing with the video
  2. Can you run the tests? There are two types of tests - C using libcheck library and Python, using pytest. We'd like to have all the tests which are presently in C - also in Python. for instance in python:
cd py_bind
python setup.py prepare
python setup.py install
cd tests
nosetests

should run 61 tests.

The nose command gives me this error while trying the tests // AttributeError: module 'collections' has no attribute 'Callable' , the cython==0.29.6 version is not available as the requirements.txt says to install it ... maybe its due to the versions

@alexlib
Copy link
Contributor

alexlib commented Mar 19, 2022

Let's have a TeamViewer session - I have never seen such an error.
Write me to email and we find some convenient time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants