Skip to content

Commit

Permalink
Merge pull request #914 from cherylking/changeMinVersionForVersionles…
Browse files Browse the repository at this point in the history
…sFeatures

Change min version for versionless features
  • Loading branch information
cherylking authored Oct 9, 2024
2 parents ab5ea67 + 4c8208a commit e5df873
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
matrix:
# test against latest update of each major Java version, as well as specific updates of LTS versions:
RUNTIME: [ol, wlp]
RUNTIME_VERSION: [24.0.0.9]
RUNTIME_VERSION: [24.0.0.10]
java: [21, 17, 11, 8]
exclude:
- java: 8
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
matrix:
# test against latest update of each major Java version, as well as specific updates of LTS versions:
RUNTIME: [ol, wlp]
RUNTIME_VERSION: [24.0.0.9]
RUNTIME_VERSION: [24.0.0.10]
java: [21, 17, 11, 8]
exclude:
- java: 8
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ apply plugin: "com.gradle.plugin-publish"
apply plugin: 'base'

group = 'io.openliberty.tools'
version = '3.8.4-SNAPSHOT'
version = '3.9.0-SNAPSHOT'
base {
archivesName='liberty-gradle-plugin'
}
Expand Down
2 changes: 1 addition & 1 deletion docs/libertyDev.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ These can also be specified as command line parameters in addition to the ones i

| Attribute | Type | Since | Description | Required |
| --------- | ----- | ----- | ----------- | -------- |
| changeOnDemandTestsAction | boolean | 3.8.4 | If set to `true`, change the action for running on demand tests from `Enter` to type `t` and press `Enter`. The default value is `false`. | No |
| changeOnDemandTestsAction | boolean | 3.9 | If set to `true`, change the action for running on demand tests from `Enter` to type `t` and press `Enter`. The default value is `false`. | No |

See the [Liberty server configuration](libertyExtensions.md#liberty-server-configuration) properties for common server configuration.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class KernelInstallVersionlessFeatureTest extends AbstractIntegrationTest{
// expect failure - check for error message
BuildResult result = runTasksFailResult(buildDir, "installFeature")
String output = result.getOutput()
assertTrue(output.contains("PluginExecutionException: Detected versionless feature(s) for installation. The minimum required Liberty version for versionless feature support is 24.0.0.9"))
assertTrue(output.contains("PluginExecutionException: Detected versionless feature(s) for installation. The minimum required Liberty version for versionless feature support is 24.0.0.10"))
}

@Test
Expand All @@ -123,17 +123,16 @@ class KernelInstallVersionlessFeatureTest extends AbstractIntegrationTest{
// expect failure - check for error message
BuildResult result = runTasksFailResult(buildDir, "installFeature")
String output = result.getOutput()
assertTrue(output.contains("Detected possible versionless feature(s) for installation. The minimum required Liberty version for versionless feature support is 24.0.0.9"))
assertTrue(output.contains("Detected possible versionless feature(s) for installation. The minimum required Liberty version for versionless feature support is 24.0.0.10"))

String messageWL = "PluginExecutionException: CWWKF1203E: Unable to obtain the following features: ejb. Ensure that the features are valid."
String messageOL = "PluginExecutionException: CWWKF1299E: The following features could not be obtained: ejb. Ensure that the features are valid for Open Liberty."
assertTrue(output.contains(messageOL) || output.contains(messageWL))
}

//@Test
// Commented out because current failure returns
// "Cannot invoke "com.ibm.ws.kernel.feature.provisioning.ProvisioningFeatureDefinition.getSymbolicName()" because the return value of "java.util.HashMap.get(Object)" is null"
// Opened issue https://github.com/OpenLiberty/ci.common/issues/452 to follow up.
@Test
// This test required a fix that is in 24.0.0.10.
// Opened issue https://github.com/OpenLiberty/ci.common/issues/452 for it.
/**
* Install with only server.xml features
*/
Expand Down

0 comments on commit e5df873

Please sign in to comment.