Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating FxMatrix #1417

Open
cjkent opened this issue Nov 22, 2016 · 0 comments
Open

Consider deprecating FxMatrix #1417

cjkent opened this issue Nov 22, 2016 · 0 comments

Comments

@cjkent
Copy link
Contributor

cjkent commented Nov 22, 2016

We have two incompatible methods of triangulating FX rates - FxMatrix and MarketDataFxRateProvider. MarketDataFxRateProvider builds FX rates by triangulating rates from a set of market data. FxMatrix is a completely stand-alone container of FX rates and performs its own triangulation.

The calculation runner indirectly uses MarketDataFxRateProvider and is therefore implicitly assuming all FX rates can be built from the rates in the market data.

If a user creates an FxMatrix and then tries to use the calculation runner the rates from the FX matrix will not be available for the calculation runner to convert the results to the reporting currency. There is no nice workaround for this - the user must unpack the individual rates from the FxMatrix and insert them into the market data.

Ultimately this problem is caused by having two ways to do the same thing. We should pick one and use it everywhere. The simplest thing would be to replace uses of FxMatrix with MarketDataFxRateProvider built from MarketData containing FX rates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant