Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command to update theme dependencies #39

Open
dermatz opened this issue Aug 6, 2024 · 1 comment
Open

Command to update theme dependencies #39

dermatz opened this issue Aug 6, 2024 · 1 comment
Assignees
Labels
feature-request New feature or request in code-review in progress will be released in next release
Milestone

Comments

@dermatz
Copy link
Collaborator

dermatz commented Aug 6, 2024

Provide a new command to update theme TailwindCSS dependencies to the latest version for specific theme or all themes with just one command like e.g. update-dependencies

💡 Idea: different update modes...

  • latest version
  • Easy updating taking version prefixes such as ^ or ~
@dermatz dermatz added the feature-request New feature or request label Aug 6, 2024
@dermatz
Copy link
Collaborator Author

dermatz commented Aug 11, 2024

I think it will be a benefit if the use can use

ddev frontend check-npm-deps themename - to check what is outdated and
ddev fronden update-npm-deps themename - to update the package.json

Both can be realized with the tool npm-check-updates:

npm install -g npm-check-updates
ncu -u

Steps:

  1. The logic need to check if the theme is a hyva theme and get the theme path to /web/tailwind folder
  • if theme is hyva-theme: go ahead
  • if theme is magento theme: exit with message, because it should be updated manually.
  1. switch to theme/web/tailwind and run ncu -u, otherwise install it with npm install -g npm-check-updates
  2. check with npm outdated if all files are uptodate
  3. ask to run the frontend build for this theme to get updated files

@dermatz dermatz added the under investigation This Task is under investigation label Aug 11, 2024
@dermatz dermatz changed the title Command to update theme dependencies Command to update hyva-theme dependencies Aug 11, 2024
@dermatz dermatz changed the title Command to update hyva-theme dependencies Command to update theme dependencies Aug 11, 2024
@dermatz dermatz added in progress will be released in next release in code-review and removed under investigation This Task is under investigation labels Aug 19, 2024
@dermatz dermatz added this to the 1.9.0 milestone Aug 19, 2024
dermatz added a commit that referenced this issue Oct 27, 2024
dermatz added a commit that referenced this issue Nov 16, 2024
@dermatz dermatz self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request in code-review in progress will be released in next release
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant