Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new solo version #5

Open
11 tasks
hendrikebbers opened this issue Oct 1, 2024 · 5 comments
Open
11 tasks

Update to new solo version #5

hendrikebbers opened this issue Oct 1, 2024 · 5 comments
Assignees
Labels
hacktoberfest Reserved for Hacktoberfest contribution (see https://hacktoberfest.com) 🚀👾🧑🏽‍💻

Comments

@hendrikebbers
Copy link
Member

hendrikebbers commented Oct 1, 2024

🆕🐥 First Timers Only

This issue is reserved for people who have never contributed to this project or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution.

👾 Description of the issue

This Github Action use the Hedera solo cli interally. You repo of solo can can be found here: https://github.com/hashgraph/solo

When creating this issue v0.31.0 is the latest release of solo: https://github.com/hashgraph/solo/releases/tag/v0.31.0
Currently the action uses solo v0.28.1. We need to update the solo version that is used in the action to the newest version. Sadly just changing the version number is not successfull since this will end in a broken GitHub Action. I assume that the CLI commands of solo has changed a little between v0.28.1 and v0.31.0. Documentation about the usage of solo can be found in the readme of the project.

Suggested solution

Update the internally used version of solo to the latest release and refactor the usage of solo in the Github Action so that the action works as expected.

📋 Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow.
A more detailed general documentation of the GitHub PR workflow can be found here.

  • Claim this issue: Comment below that you are interested in working on the issue
  • Wait for assignment: A community member with the given rights will add you as an assignee of the issue
  • Fork the repository: You can do that in GitHub (by simply clicking the 'fork' button).
  • Check out the forked repository
  • Create a feature branch for the issue. We do not have a hard naming definition for branches but it is best practice to prefix the branch name with the issue id.
  • Solve the issue in your branch.
  • Commit your changes: to your branch
  • Start a Pull Request (PR): in the hedera-enterprise repository
  • Check GitHub Actions: Several GitHub Actions will be triggered automatically for each PR. If a GitHub Action fails and you do not understand the cause of that error do not hesitate to add a comment to the PR and ask the community for support.
  • Wait for reviews: Members of the community will review your PR. If a reviewer finds any missing pieces or a problem, he or she will start a discussion with you and describe the next steps for solving the problem.
  • You did it 🎉: We will merge the fix in the develop branch. Thanks for being part of our community as an open-source contributor ❤️

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

🤔 Additional informantion

If you have any questions, just ask us directly in this issue by adding a comment. You can join the Hedera community chat at Discord. A general manual about open-source contributions can be found here.

@hendrikebbers hendrikebbers added the good first issue candidate Label for issues that should be labeled by 'good first issue' but missing a good documentation label Oct 1, 2024
@hendrikebbers hendrikebbers removed the good first issue candidate Label for issues that should be labeled by 'good first issue' but missing a good documentation label Oct 15, 2024
@omsuneri
Copy link

@hendrikebbers please assign me this issue i ll work on it

@hendrikebbers hendrikebbers added the hacktoberfest Reserved for Hacktoberfest contribution (see https://hacktoberfest.com) 🚀👾🧑🏽‍💻 label Oct 17, 2024
@Phransis
Copy link

I'm interested

@Ndacyayisenga-droid
Copy link
Member

@Phransis @omsuneri is any of you still interested in this issue?

@Phransis
Copy link

Phransis commented Nov 14, 2024 via email

@Phransis
Copy link

Phransis commented Nov 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Reserved for Hacktoberfest contribution (see https://hacktoberfest.com) 🚀👾🧑🏽‍💻
Projects
None yet
Development

No branches or pull requests

4 participants