Implementation of Exception Handling for Misaligned DOWNCONFIGs #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request implements a TODO found in the main API file:
# TODO could check that every down config for each list_path is on the same row. Things will get odd if they are not.
A new private function (
_validate_down_configs
) handles the validation after the_build_all_configs_in_excel_sheet
function. The exception is implemented similarly toMissingWorksheetException
, where the end-user can toggle the behaviour of the exception to either halt or skip gracefully.Changes Included