Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Exception Handling for Misaligned DOWNCONFIGs #34

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

thatvideoshopguy
Copy link

Overview

This pull request implements a TODO found in the main API file:

# TODO could check that every down config for each list_path is on the same row. Things will get odd if they are not.

A new private function (_validate_down_configs) handles the validation after the _build_all_configs_in_excel_sheet function. The exception is implemented similarly to MissingWorksheetException, where the end-user can toggle the behaviour of the exception to either halt or skip gracefully.

Changes Included

  • Misaligned Down Configs: Implemented functionality to handle misaligned 'down configs' within form processing, allowing for more robust data integrity checks and error handling.
  • Changelog Update: Updated the CHANGELOG to reflect the latest changes and introduced a new patch version.
  • Test Refinements: Altered existing tests to trigger a raised exception for misaligned 'down configs', ensuring the test suite aligns with the new validation logic.
  • Code Linting: Addressed a minor formatting issue to pass lint workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant