Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When projectId is not present, the error yields an additional error #289

Open
phavekes opened this issue Nov 30, 2024 · 2 comments
Open

Comments

@phavekes
Copy link
Member

This issue is imported from pivotal - Originaly created at Jul 9, 2024 by Michiel Kodde

Trace

Jul  9 12:07:34 sv2310390 STEPUP-TIQR[349389]:
Jul  9 12:07:34 sv2310390 STEPUP-TIQR[349389]: {"message":"Uncaught PHP Exception InvalidArgumentException: \"The controller for URI \"/authentication\" is not callable: Value \"<NULL>\" expected to be string, type NULL given.\" at ControllerResolver.php line 98","context":{"exception":{"class":"InvalidArgumentException","message":"The controller for URI \"/authentication\" is not callable: Value \"<NULL>\" expected to be string, type NULL given.","code":0,"file":"/apps/installation/Stepup-Tiqr/Stepup-tiqr-4.0.3/vendor/symfony/http-kernel/Controller/ControllerResolver.php:98","previous":{"class":"Assert\\InvalidArgumentException","message":"Value \"<NULL>\" expected to be string, type NULL given.","code":16,"file":"/apps/installation/Stepup-Tiqr/Stepup-tiqr-4.0.3/vendor/beberlei/assert/lib/Assert/Assertion.php:2728"}}},"level":500,"level_name":"CRITICAL","channel":"request","datetime":"2024-07-09T12:07:34+02:00","extra":{"art":"19420","server":"tiqr.stepup-acc.rijk.sson.overheid-i.nl","application":"stepup-tiqr","request_id":"eea4f69db9baea9aab7019225489e93a"}}```

**Additional detail**

TvD:
> De eerste foutmelding kwam omdat we geen projectId in de config hadden staan, maar die tweede lijkt wel een bugje.. Eentje die zich alleen voordoet bij een fout-conditie, want na het toevoegen van projectId zijn ze allebei weg

**Tiqr version:**

`4.0.4`
@phavekes
Copy link
Member Author

First error is here: https://github.com/OpenConext/Stepup-tiqr/blob/main/src/Tiqr/TiqrConfiguration.php#L71
Second error is the service instatiation that fails because of the failed assertion above:

$tiqrConfiguration: '%tiqr_library_options%'

The exception escapes from the TiqrConfiguration constructor. @michielkodde is there a better way of doing this? (Pieter van der Meulen - Jul 10, 2024)

@phavekes
Copy link
Member Author

Yes, the Symfony Configuration component could/should parse this config. And report missing/misconfigured config options when building the app cache.

Why the second exception is raised (with the ControllerResolver) does not ring a bell with me. I did some research and found this old issue: https://github.com/symfony/symfony/issues/23997. But why the controller tries to resolve the missing config parameter I do not understand. (Michiel Kodde - Jul 10, 2024)

@phavekes phavekes removed their assignment Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

No branches or pull requests

1 participant