Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when required attributes are missing #430

Open
phavekes opened this issue Dec 1, 2024 · 1 comment
Open

Improve error message when required attributes are missing #430

phavekes opened this issue Dec 1, 2024 · 1 comment

Comments

@phavekes
Copy link
Member

phavekes commented Dec 1, 2024

This issue is imported from pivotal - Originaly created at Apr 9, 2020 by Peter Havekes

The log shows:

messages:Apr  8 13:57:53 sa-test-app.surfconext.nl stepup-selfservice[119612]: {"channel":"app","level":"ERROR","message":"Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\HttpException: \"Missing value for required attribute \"commonName\"\" at /opt/stepup/Stepup-SelfService-3.1.0-20200123094957Z-899924d0139418958a9e502aa52eeea34494053d/vendor/symfony/symfony/src/Symfony/Component/Security/Http/Firewall/ExceptionListener.php line 190","context":{"exception":{"class":"Symfony\\Component\\HttpKernel\\Exception\\HttpException","message":"Missing value for required attribute \"commonName\"","code":0,"file":"/opt/stepup/Stepup-SelfService-3.1.0-20200123094957Z-899924d0139418958a9e502aa52eeea34494053d/vendor/symfony/symfony/src/Symfony/Component/Security/Http/Firewall/ExceptionListener.php:190","previous":{"class":"Surfnet\\StepupSelfService\\SelfServiceBundle\\Exception\\MissingRequiredAttributeException","message":"Missing value for required attribute \"commonName\"","code":0,"file":"/opt/stepup/Stepup-SelfService-3.1.0-20200123094957Z-899924d0139418958a9e502aa52eeea34494053d/src/Surfnet/StepupSelfService/SelfServiceBundle/Security/Authentication/Provider/SamlProvider.php:122"}}},"extra":{"art":"32881","server":"sa.test.surfconext.nl","application":"self-service","request_id":"aa25f6bba864e2cfb7a9471687a2fea2"}}

But the user sees "Something went wrong; please try again" (see screenshot).
The user should be informed about the missing information.

@phavekes
Copy link
Member Author

phavekes commented Dec 1, 2024

(Peter Havekes - Apr 9, 2020)

@phavekes phavekes removed their assignment Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

No branches or pull requests

1 participant