Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for end users in AzureMFA gssp #510

Open
phavekes opened this issue Dec 1, 2024 · 2 comments
Open

Improve error messages for end users in AzureMFA gssp #510

phavekes opened this issue Dec 1, 2024 · 2 comments

Comments

@phavekes
Copy link
Member

phavekes commented Dec 1, 2024

This issue is imported from pivotal - Originaly created at May 7, 2020 by Peter Havekes

All errors are shown as "Something went wrong, please try again". The logs show useful messages at the same moment. These error-messages can help users, of help our support-users to provide the right solution.

These error messages show up in the logs, and should also be shown on the user-facing error pages:

  • The NameId from the Azure MFA assertion did not match the NameId provided during registration
  • ADFS AuthnRequest requests ACS location but it is not configured in the list of allowed ACS locations
  • Unable to validate Signature

EST. 4h

@phavekes
Copy link
Member Author

phavekes commented Dec 1, 2024

(Peter Havekes - May 7, 2020)

@phavekes
Copy link
Member Author

phavekes commented Dec 1, 2024

Possibly related: If an exception is trown during registration, the user is redirected to the /registration/ page, without any information. eg MailAttributeMismatchException

https://github.com/OpenConext/Stepup-Azure-MFA/blob/3866bfee49423079300531e89eb69709d25be792/src/Surfnet/AzureMfa/Application/Service/AzureMfaService.php#L225 (Peter Havekes - Dec 2, 2020)

@phavekes phavekes removed their assignment Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

No branches or pull requests

1 participant