From c118697b722e4bac0a20c41f9400d8afd49af90e Mon Sep 17 00:00:00 2001
From: Bas <bstrooband@ibuildings.nl>
Date: Tue, 17 Dec 2024 11:28:44 +0100
Subject: [PATCH] Minor changes after review

---
 ci/qa/create-test-db                                 | 8 --------
 ci/qa/phpunit                                        | 2 --
 src/Surfnet/Stepup/Identity/Value/UnhashedSecret.php | 4 +++-
 3 files changed, 3 insertions(+), 11 deletions(-)
 delete mode 100755 ci/qa/create-test-db

diff --git a/ci/qa/create-test-db b/ci/qa/create-test-db
deleted file mode 100755
index ab23a004d..000000000
--- a/ci/qa/create-test-db
+++ /dev/null
@@ -1,8 +0,0 @@
-#!/usr/bin/env bash
-
-cd $(dirname $0)/../../
-
-printf "\nCreating 'middleware' test database\n\n"
-
-./bin/console doctrine:schema:drop -qf --env=test
-./bin/console doctrine:schema:create -q --env=test
diff --git a/ci/qa/phpunit b/ci/qa/phpunit
index 60d577c1c..e402c8609 100755
--- a/ci/qa/phpunit
+++ b/ci/qa/phpunit
@@ -5,8 +5,6 @@ set -e
 
 cd $(dirname $0)/../../
 
-#./ci/qa/create-test-db
-
 # PHPUnit Bridge should always be used in Symfony applications. (https://symfony.com/doc/current/components/phpunit_bridge.html)
 # This will create a phpunit executable in /bin/ instead of /vendor/bin/
 ./vendor/bin/phpunit --configuration=ci/qa/phpunit.xml --coverage-text --stop-on-error $1
diff --git a/src/Surfnet/Stepup/Identity/Value/UnhashedSecret.php b/src/Surfnet/Stepup/Identity/Value/UnhashedSecret.php
index da0fa4422..6c2c9e15d 100644
--- a/src/Surfnet/Stepup/Identity/Value/UnhashedSecret.php
+++ b/src/Surfnet/Stepup/Identity/Value/UnhashedSecret.php
@@ -18,6 +18,8 @@
 
 namespace Surfnet\Stepup\Identity\Value;
 
+use SensitiveParameter;
+
 /**
  * Unhashed secret
  *
@@ -51,7 +53,7 @@ public function hashSecret(): HashedSecret
         return new HashedSecret($hashedSecret);
     }
 
-    public function __construct(private readonly string $secret)
+    public function __construct(#[SensitiveParameter] private readonly string $secret)
     {
     }