From a0f90b2ef2061ec23f01f1a83c4c674c426f1233 Mon Sep 17 00:00:00 2001
From: Okke Harsta <oharsta@zilverline.com>
Date: Wed, 15 Nov 2023 10:11:00 +0100
Subject: [PATCH] Changed read more links

---
 client/src/locale/en.js             | 5 ++---
 client/src/locale/nl.js             | 3 +--
 welcome/src/components/RoleCard.jsx | 4 ++--
 welcome/src/locale/en.js            | 5 ++---
 welcome/src/locale/nl.js            | 3 +--
 5 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/client/src/locale/en.js b/client/src/locale/en.js
index 96db803a..0982e4cc 100644
--- a/client/src/locale/en.js
+++ b/client/src/locale/en.js
@@ -20,7 +20,7 @@ const en = {
             ["Groups", "<p>The roles are actually group memberships that can be provisioned to external SCIM API's.</p>", false]
         ],
         footer: "<p>SURFconext Invite is a service for access management to SURFconext-connected service providers.</p>" +
-            "<p>Do you want to know more? Please visit <a href='https://surf.nl/en/invite'>https://surf.nl/en/invite</a>.</p>",
+            "<p>Do you want to know more? <a href='https://support.surfconext.nl/invite-en'>Read more</a>.</p>",
     },
     header: {
         title: "SURFconext Invite",
@@ -33,8 +33,7 @@ const en = {
             access: "Access",
             help: "Help",
             profile: "Profile",
-            logout: "Logout",
-            helpUrl: "https://support.surfconext.nl/help-invite-en"
+            logout: "Logout"
         },
     },
     tabs: {
diff --git a/client/src/locale/nl.js b/client/src/locale/nl.js
index a5ff10d2..8fafea4f 100644
--- a/client/src/locale/nl.js
+++ b/client/src/locale/nl.js
@@ -33,8 +33,7 @@ const nl = {
             access: "Invite",
             help: "Help",
             profile: "Profiel",
-            logout: "Log uit",
-            helpUrl: "https://support.surfconext.nl/help-invite-nl"
+            logout: "Log uit"
         },
     },
     tabs: {
diff --git a/welcome/src/components/RoleCard.jsx b/welcome/src/components/RoleCard.jsx
index 417394b1..66543a87 100644
--- a/welcome/src/components/RoleCard.jsx
+++ b/welcome/src/components/RoleCard.jsx
@@ -4,7 +4,7 @@ import Logo from "./Logo";
 import I18n from "../locale/I18n";
 import {MoreLessText} from "./MoreLessText";
 import {Button, Card, CardType, Chip, ChipType} from "@surfnet/sds";
-import {sanitizeURL} from "../utils/Utils";
+import {isEmpty, sanitizeURL} from "../utils/Utils";
 
 
 export const RoleCard = ({role, index, isNew = false, skipLaunch= false}) => {
@@ -18,7 +18,7 @@ export const RoleCard = ({role, index, isNew = false, skipLaunch= false}) => {
                 <h3>{role.name}</h3>
                 <MoreLessText txt={role.description} cutOffNumber={120}/>
             </section>
-            {!skipLaunch && <div className={"launch"}>
+            {(!skipLaunch && !isEmpty(role.landingPage)) && <div className={"launch"}>
                 <Button txt={I18n.t("proceed.launch")} onClick={() => {
                     window.location.href = sanitizeURL(role.landingPage);
                 }}/>
diff --git a/welcome/src/locale/en.js b/welcome/src/locale/en.js
index 1f5f50c7..1a67ff3f 100644
--- a/welcome/src/locale/en.js
+++ b/welcome/src/locale/en.js
@@ -20,7 +20,7 @@ const en = {
             ["Groups", "<p>The roles are actually group memberships that can be provisioned to external SCIM API's.</p>", false]
         ],
         footer: "<p>SURFconext Invite is a service for access management of Dutch led service providers.</p>" +
-            "<p>Do you want to know more? Please visit <a href='https://surf.nl/en/invite'>https://surf.nl/en/invite</a>.</p>",
+            "<p>Do you want to know more? <a href='https://support.surfconext.nl/invite-en'>Read more</a>.</p>",
     },
     header: {
         title: "SURFconext Invite",
@@ -32,8 +32,7 @@ const en = {
             access: "Access",
             help: "Help",
             profile: "Profile",
-            logout: "Logout",
-            helpUrl: "https://support.surfconext.nl/help-invite-en"
+            logout: "Logout"
         },
     },
     home: {
diff --git a/welcome/src/locale/nl.js b/welcome/src/locale/nl.js
index ec92f9cf..8ae39e9d 100644
--- a/welcome/src/locale/nl.js
+++ b/welcome/src/locale/nl.js
@@ -32,8 +32,7 @@ const nl = {
             access: "Invite",
             help: "Help",
             profile: "Profiel",
-            logout: "Log uit",
-            helpUrl: "https://support.surfconext.nl/help-invite-nl"
+            logout: "Log uit"
         },
     },
     home: {