Add depth-of-field (Blurring rendering options) #492
Conversation
Signed-off-by: Perminder <[email protected]>
|
Thanks for opening this pull request! Please check out our contributing guidelines and check for the automated tests. |
|
This pull request has been mentioned on Avogadro Discussion. There might be relevant details there: https://discuss.avogadro.cc/t/add-depth-of-field-fog-or-blurring-rendering-options/5332/9 |
Signed-off-by: Perminder <[email protected]>
Signed-off-by: Perminder <[email protected]>
| @@ -389,6 +389,8 @@ void MainWindow::setupInterface() | |||
| if (pipeline) { | |||
| pipeline->setAoEnabled( | |||
| settings.value("MainWindow/ao_enabled", true).toBool()); | |||
| pipeline->setDofEnabled( | |||
| settings.value("MainWindow/dof_enabled", true).toBool()); | |||
There was a problem hiding this comment.
Consider disabling DoF by default to optimize performance for lower-end systems. Users can enable it as needed via settings. Thoughts? @ghutchis
There was a problem hiding this comment.
Thanks, this is still a work in progress PR and i want the shader file to be the best as needed and required. If you have any suggestions in this file for now https://github.com/OpenChemistry/avogadrolibs/pull/1662/files#diff-4f4a09755e6a3ad5776a815bd446b9ee8850fa794fea3aa67c1b1e2bd59e808e then please let me know.
I plan to incorporate various user settings for enabling and disabling depth of field (DOF) once the .glsl file functions as intended. While it's currently functional, I aim to align with @ghutchis plans for this feature.
Signed-off-by: Perminder <[email protected]>
Signed-off-by: Perminder <[email protected]>
issue : OpenChemistry/avogadrolibs#347
complementary to : OpenChemistry/avogadrolibs#1662
signed off by: [email protected]
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.