Replies: 2 comments 1 reply
-
That sounds good to me! |
Beta Was this translation helpful? Give feedback.
1 reply
-
Sounds great! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This project has already seen a ton of interest in spite of the difficulty in getting it installed. I expect in the future that the amount of contributors to skyrocket judging from the forks and the stars. To maintain velocity and operational excellence we are going to need end to end automation. I hope this discussion helps facilitate both the design and the implementation.
Goals:
The PR workflow I propose is:
pre-commit
to run CI/CD locally for every commitWhen a merge happens into
develop
we will want to:The plan is to allow multiple merges into
develop
and continue to create release candidates until we are ready to actually release a new version by opening a PR fromdevelop
intomain
.When a PR is merged to
main
:If we can build a pipeline to do all the steps we would be in a really great position. The
develop
section is actually the hardest. Lots of github actions can help us create tags, create gthub releases etc but not all of them do tags and stuff in the format that pypi specifies. Thankfully we can usepoetry
to help with most of that. It has some limitations that I have outlined here.Say the version of the application is
1.0.0
. If apatch
PR is merged intodevelop
then we need to create a1.0.1-alpha
tag. If a second patch is merged then we need to update the tag to1.0.1-alpha.1
. If aminor
PR is merged into developthen we need to create
1.1.0-alphatag. If another
patchPR is merged the tag should be
1.1.0-alpha.1`.It seems pretty straight forward but it will be a complicated workflow to implement. I have implemented about 85% of this for other projects in the past and I think 100% e2e is doable nowadays.
Feel free to share your thoughts but we need both the docker and pip stuff now. So I will begin implementing parts of this in the next few days.
@DidierRLopes @cclauss @akx
Beta Was this translation helpful? Give feedback.
All reactions