Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/geojson: Use libcoveofds, not ofdskit #204

Merged
merged 1 commit into from
Dec 1, 2022
Merged

examples/geojson: Use libcoveofds, not ofdskit #204

merged 1 commit into from
Dec 1, 2022
+63 −11

Conversation

odscjames
Copy link
Collaborator

Related issues

#19

@odscjames odscjames requested a review from lgs85 December 1, 2022 15:15
@odscjames odscjames self-assigned this Dec 1, 2022
@odscjames
Copy link
Collaborator Author

Should this have an entry for the changes to the example files?

@lgs85
Copy link
Contributor

lgs85 commented Dec 1, 2022

Should this have an entry for the changes to the example files?

Yes please! Something like:

#204 - Update GeoJSON examples.

Should do it.

@odscjames odscjames force-pushed the 2022-11-12-switch-to-new-lib branch from c3dbd8d to f5f19b4 Compare December 1, 2022 15:33
lgs85
lgs85 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@lgs85 lgs85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@odscjames odscjames merged commit 4bf83d5 into 0.1-dev Dec 1, 2022
@odscjames odscjames deleted the 2022-11-12-switch-to-new-lib branch December 1, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgs85 lgs85 lgs85 approved these changes

Assignees

@odscjames odscjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odscjames @lgs85