-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Actions/Tests/Precommit: Capitalise all Codelist CSV file headers? #227
Comments
I'm happy with capitalised headers. In #166 we started to add a schema for testing codelists. If there are exceptions in the future we can handle that either in the schema or the tests that use it. |
For reference that is https://github.com/Open-Telecoms-Data/open-fibre-data-standard/blob/ded3cb39d35ced8d41388adf32fe8be48831f061/schema/codelist-schema.json Commits However I can't find anything in #166 that actually uses that schema to test the code lists - is that still to be written or am I missing something? |
@duncandewhurst @odscjames |
Simple codelist schema missing regex for the Code value. WIP. #227
Simple codelist schema missing regex for the Code value. WIP. #227
Think this is now done? |
Yep! |
One of the things done in #166 is to Capitalise all Codelist CSV file headers but there is no corresponding test for that - do we want one? Or might there be possible exceptions in the future?
Split out from #19
The text was updated successfully, but these errors were encountered: