Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions/Tests/Precommit: Capitalise all Codelist CSV file headers? #227

Closed
odscjames opened this issue Dec 14, 2022 · 6 comments
Closed
Labels
Build This issue relates to the build process

Comments

@odscjames
Copy link
Collaborator

odscjames commented Dec 14, 2022

One of the things done in #166 is to Capitalise all Codelist CSV file headers but there is no corresponding test for that - do we want one? Or might there be possible exceptions in the future?

Split out from #19

@duncandewhurst
Copy link
Collaborator

I'm happy with capitalised headers. In #166 we started to add a schema for testing codelists. If there are exceptions in the future we can handle that either in the schema or the tests that use it.

@duncandewhurst duncandewhurst added the Build This issue relates to the build process label Dec 16, 2022
@odscjames
Copy link
Collaborator Author

For reference that is https://github.com/Open-Telecoms-Data/open-fibre-data-standard/blob/ded3cb39d35ced8d41388adf32fe8be48831f061/schema/codelist-schema.json

Commits

However I can't find anything in #166 that actually uses that schema to test the code lists - is that still to be written or am I missing something?

@duncandewhurst
Copy link
Collaborator

However I can't find anything in #166 that actually uses that schema to test the code lists - is that still to be written or am I missing something?

I don't know. @Lathrisk could you confirm where you got up to please?

@Lathrisk
Copy link
Contributor

@duncandewhurst @odscjames
I had added a draft schema, but not any associated tests when James took over this work. I planned to use the equivalent test elsewhere as a base.

odscjames pushed a commit that referenced this issue Dec 20, 2022
Simple codelist schema missing regex for the Code value. WIP.

#227
odscjames pushed a commit that referenced this issue Dec 20, 2022
odscjames added a commit that referenced this issue Dec 20, 2022
odscjames pushed a commit that referenced this issue Dec 20, 2022
Simple codelist schema missing regex for the Code value. WIP.

#227
odscjames pushed a commit that referenced this issue Dec 20, 2022
odscjames added a commit that referenced this issue Dec 20, 2022
@odscjames
Copy link
Collaborator Author

Think this is now done?

@duncandewhurst
Copy link
Collaborator

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build This issue relates to the build process
Projects
None yet
Development

No branches or pull requests

3 participants