Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript]: export types and interfaces for reuse (still missing export in 3.0.0) #108

Open
NotEvenANeko opened this issue Apr 17, 2023 · 2 comments
Labels
Enhancement / Feature New feature or request

Comments

@NotEvenANeko
Copy link

What's on your mind?

For example, I want to make a React hook like

export const useOneSignal = (options?: Parameters<(typeof OneSignal)['init']['0']>): [ready: boolean, instance: typeof OneSignal]

and I have to use Parameters<(typeof OneSignal)['init']['0']> instead of IInitObject.

Export IInitObject and other types can make this function signature easier to write.

@emawby emawby added the Enhancement / Feature New feature or request label Apr 17, 2023
@emawby
Copy link
Contributor

emawby commented Apr 17, 2023

Thank you for reaching out, we will evaluate this!

@jkasten2 jkasten2 changed the title [TypeScript]: export types and interfaces for reuse [TypeScript]: export types and interfaces for reuse (still missing export in 3.0.0) Aug 16, 2023
@ElwynVdb
Copy link

Is there any update on this? I'm working on a project where I have to implement oneSignal.
The types would come in handy for creating callbacks and related hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement / Feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants