Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Update release process #762

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Oct 30, 2024

Description

One Line Summary

Updates the release process to remove some manual tasks

Details

Motivation

Removes some manual tasks done during the release process

Scope

  • Updates the bash script to update the version number in additional files that were added in User Model, and the .asmdef files.
  • Updates Asset Store Tools to v11.4.3 and removes its legacy files
    • Legacy files were causing conflicts when trying to upgrade Asset Store Tools in older versions of the Unity Editor: like 2021.3.0f1.

Testing

Manual testing

  • Ran composeRelease.sh without the git steps and saw the appropriate files get updated.
  • Opened the example project in Unity 2021.3.0f1 and saw the v11.4.3 Asset Store Tools menu.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant