Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Model] Upgrade to .NET 7 #83

Merged
merged 19 commits into from
Jan 5, 2024
Merged

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Dec 16, 2023

Things I needed to do to get the extension to work

To get extension to recognize dotnet tools
Add .NET Install Tool extension

To get Android tools to work
Create a new project:

  • dotnet new maui
  • Dotnet restore
  • sudo dotnet workload restore
  • dotnet build -t:InstallAndroidDependencies -f:net7.0-android -p:AndroidSdkDirectory="$HOME/Library/Android/sdk" -p:AcceptAndroidSDKLicenses=True

To choose a debug target:

  • command p to pull up pallete
  • maui

  • choose iOS device

  • Click brackets at bottom and pin debug target

To choose the csproj to run and debug

Right click solution and close solution
Click open solution

Description

One Line Summary

This PR bumps to .net7 and uses the new VSCode + extension workflow for developing on mac.

Details

All instances of .net6 were bumped to .net7 and we are no longer using the Xamarin Legacy SDK. Isntead we are using Microsoft.NET.Sdk in our project.
Additionally the project has been updated to run is VSCode with the maui extension.

Motivation

The Xamarin Legacy SDK has been causing issues building on iOS and is no longer receiving support for new iOS versions. We are moving to the .Net SDK for a more consistent and stable developer experience

Scope

project build settings.

Manual testing

Tested iOS and Android builds using VSCode + extensions

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

@emawby emawby changed the title [User Model] WiP Upgrade to .NET 7 [User Model] Upgrade to .NET 7 Dec 19, 2023
Copy link
Contributor

@shepherd-l shepherd-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I was able to run the example app with Visual Studio Code and initialize OneSignal on
Android Emulator: Pixel 4 API 31
iOS Simulator: iPhone 15 iOS 17

@emawby emawby merged commit 046bdef into user-model/main Jan 5, 2024
1 check passed
@emawby emawby deleted the user-model/dotnet7-upgrade branch January 5, 2024 19:04
@emawby emawby mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants