-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User Model] Upgrade to .NET 7 #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update OneSignalSDK.DotNet.csproj
also removes xamarin
emawby
changed the title
[User Model] WiP Upgrade to .NET 7
[User Model] Upgrade to .NET 7
Dec 19, 2023
emawby
force-pushed
the
user-model/dotnet7-upgrade
branch
from
December 19, 2023 20:27
674badb
to
de8eb8c
Compare
emawby
requested review from
nan-li,
jinliu9508,
shepherd-l,
jennantilla and
jkasten2
December 19, 2023 20:30
This crashes with a target invocation exception
shepherd-l
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I was able to run the example app with Visual Studio Code and initialize OneSignal on
Android Emulator: Pixel 4 API 31
iOS Simulator: iPhone 15 iOS 17
[User Model] Add GetTags
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things I needed to do to get the extension to work
To get extension to recognize dotnet tools
Add .NET Install Tool extension
To get Android tools to work
Create a new project:
To choose a debug target:
To choose the csproj to run and debug
Description
One Line Summary
This PR bumps to .net7 and uses the new VSCode + extension workflow for developing on mac.
Details
All instances of .net6 were bumped to .net7 and we are no longer using the Xamarin Legacy SDK. Isntead we are using Microsoft.NET.Sdk in our project.
Additionally the project has been updated to run is VSCode with the maui extension.
Motivation
The Xamarin Legacy SDK has been causing issues building on iOS and is no longer receiving support for new iOS versions. We are moving to the .Net SDK for a more consistent and stable developer experience
Scope
project build settings.
Manual testing
Tested iOS and Android builds using VSCode + extensions
Affected code checklist
Checklist
Overview
Testing
Final pass