Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration warning to readme and migration guide #103

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Apr 12, 2024

This PR adds a feature parity migration warning to the migration guide and readme.md

@@ -1,3 +1,18 @@

⚠️ Migration Advisory for current OneSignal customers
Copy link
Contributor

@shepherd-l shepherd-l Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This could be made into a header like on iOS to make it linkable
And perhaps put the warning below the Migration Guide Title

@emawby emawby merged commit 4faa752 into main Apr 15, 2024
1 check passed
@emawby emawby deleted the add_warning_to_readme branch April 15, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants