Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] DictToNSDict string values #78

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Nov 2, 2023

Description

One Line Summary

Fixes the values being sent on iOS when calling AddTriggers, AddAliases, and AddTags.

Details

Motivation

Fixes #74

Scope

OneSignal iOS methods with paramIDictionary<string, string>

  • AddTriggers
  • AddAliases
  • AddTags

Testing

Manual testing

Tested addTags with multiple tags, app deployed with Visual Studio Code with the example app on an iOS simulator iPhone 15 with iOS 17.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

@emawby emawby self-requested a review November 2, 2023 17:55
@shepherd-l shepherd-l mentioned this pull request Jan 4, 2024
18 tasks
@emawby
Copy link
Contributor

emawby commented Jan 5, 2024

Let's rebase this to get the .net7 changes and then re-test

@shepherd-l
Copy link
Contributor Author

I re-tested addTags with multiple tags and the values were correct

@emawby emawby merged commit ae82af4 into user-model/main Jan 11, 2024
1 check passed
@emawby emawby deleted the fix/dictToNSDictValues branch January 11, 2024 19:28
@emawby emawby mentioned this pull request Jan 24, 2024
@shepherd-l shepherd-l restored the fix/dictToNSDictValues branch February 20, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants