Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Unicode issue in paths #115

Closed
dfeinzeig opened this issue Sep 28, 2017 · 3 comments
Closed

Unicode issue in paths #115

dfeinzeig opened this issue Sep 28, 2017 · 3 comments

Comments

@dfeinzeig
Copy link

If the path passed to

https://github.com/OneDrive/onedrive-sdk-python/blob/master/src/onedrivesdk/extensions/drive_request_builder_helper.py#L40

contains a unicode character it blows up with a unicode error. Is it valid to have unicode characters in paths in onedrive? if so, this should be updated.

DataSapient added a commit to DataSapient/onedrive-sdk-python that referenced this issue Oct 4, 2018
@DataSapient
Copy link

This PR(#137) may address and provide a quick fix for this issue considering unicode character is not allowed in paths.

@KTibow
Copy link

KTibow commented Mar 16, 2020

@DataSapient I recommend you have this behavior implemented in your PR:

  1. Include it in the docs
  2. By default remove unicode characters
  3. Raise a warning when it removes unicode characters, by default
  4. Have an option on whether to remove unicode or not
  5. If they manually say they want to remove unicode not raise a warning
    That should keep everyone happy.

@baywet
Copy link
Member

baywet commented Oct 2, 2024

Thank you for reaching out and for your patience. This SDK is being officially deprecated. See #209 for more information

@baywet baywet closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants