Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow struct references within sol_interface macro #139

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

rory-ocl
Copy link
Contributor

@rory-ocl rory-ocl commented Jul 31, 2024

fixes #74

Description

Allows references to structs within the sol_interface! macro.

Would like to consider what to do for paths containing the dot separator in solidity before merging.
Path with separator will be unsupported for now. Added to docstring for clarity.

Checklist

  • I have documented these changes where necessary.
  • I have read the DCO and ensured that these changes comply.
  • I assign this work under its open source licensing.

Sorry, something went wrong.

fixes #74
@rory-ocl rory-ocl changed the base branch from stylus to develop July 31, 2024 19:19
@rory-ocl rory-ocl marked this pull request as ready for review August 6, 2024 17:40
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rory-ocl rory-ocl merged commit 15d7cfe into develop Aug 6, 2024
8 of 10 checks passed
@hkalodner hkalodner deleted the sol-interface-struct branch October 14, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Solidity struct type support in sol_interface! macro
2 participants