Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIT-2799] Add mock external signer binary #2842

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Dec 19, 2024

Fixes: NIT-2799

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Dec 19, 2024
@amsanghi amsanghi changed the title Add mock external signer binary [NIT-2799] Add mock external signer binary Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 22.67%. Comparing base (36ac667) to head (5fb7c01).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2842      +/-   ##
==========================================
+ Coverage   22.56%   22.67%   +0.10%     
==========================================
  Files         269      269              
  Lines       39696    39709      +13     
==========================================
+ Hits         8957     9003      +46     
+ Misses      29260    29237      -23     
+ Partials     1479     1469      -10     

@amsanghi amsanghi marked this pull request as ready for review December 19, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant