Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stylus: prepare support for cross-compilation #2417

Closed
wants to merge 17 commits into from
Closed

stylus: prepare support for cross-compilation #2417

wants to merge 17 commits into from

Conversation

tsahee
Copy link
Contributor

@tsahee tsahee commented Jun 20, 2024 •
edited
Loading

  • split on-cahin activation from local compilation
  • introduce target-cache that stores target configs by name
  • add name param to stylus_compile

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jun 20, 2024
@tsahee tsahee changed the title stylus: internally split compile from activate stylus: support cross-compilation Jun 26, 2024
@tsahee tsahee changed the title stylus: support cross-compilation stylus: prepare support for cross-compilation Jun 26, 2024
@magicxyyz magicxyyz mentioned this pull request Aug 7, 2024
Merged
magicxyyz
magicxyyz requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, added a nitpicking comment + there's one typo

arbitrator/stylus/src/target_cache.rs Show resolved Hide resolved
arbitrator/stylus/src/target_cache.rs Show resolved Hide resolved
@tsahee
Copy link
Contributor Author

tsahee commented Aug 16, 2024

included in #2463

@tsahee tsahee closed this Aug 16, 2024
@tsahee tsahee deleted the stylus_target branch August 16, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicxyyz magicxyyz magicxyyz requested changes

@ganeshvanahalli ganeshvanahalli Awaiting requested review from ganeshvanahalli

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsahee @magicxyyz