Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIT-2528] fix: CleanCacheSize from hashdb.Config expects a value defined in byt… #2312

Merged
merged 1 commit into from
May 20, 2024
Merged

[NIT-2528] fix: CleanCacheSize from hashdb.Config expects a value defined in byt… #2312

merged 1 commit into from
May 20, 2024

Conversation

diegoximenes
Copy link
Contributor

@diegoximenes diegoximenes commented May 17, 2024 •
edited
Loading

fix: CleanCacheSize from hashdb.Config expects a value defined in bytes, and not in MB as TrieCleanLimit is defined

@diegoximenes
fix: CleanCacheSize from hashdb.Config expects a value defined in byt…
804e4fa 
…es, and not as in MB as TrieCleanLimit is defined
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 17, 2024
@joshuacolvin0 joshuacolvin0 requested a review from magicxyyz May 17, 2024 23:46
magicxyyz
magicxyyz approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! LGTM

@diegoximenes diegoximenes merged commit 15b6ccb into master May 20, 2024
10 checks passed
@diegoximenes diegoximenes deleted the fix/staterecovery_cacheconfig branch May 20, 2024 12:44
@diegoximenes diegoximenes changed the title fix: CleanCacheSize from hashdb.Config expects a value defined in byt… [NIT-2528] fix: CleanCacheSize from hashdb.Config expects a value defined in byt… May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicxyyz magicxyyz magicxyyz approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegoximenes @magicxyyz