Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testconstants.go #2301

Merged
merged 3 commits into from
May 17, 2024
Merged

Update testconstants.go #2301

merged 3 commits into from
May 17, 2024

Conversation

ImJeremyHe
Copy link
Contributor

@ImJeremyHe ImJeremyHe commented May 14, 2024 •
edited
Loading

Since this file is expected to be used with cgo, I think it is a good practice to add the constraints even it can be built successfully.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 14, 2024
@joshuacolvin0 joshuacolvin0 requested a review from tsahee May 16, 2024 23:00
tsahee
tsahee approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 enabled auto-merge May 16, 2024 23:46
@joshuacolvin0 joshuacolvin0 merged commit 83d8c61 into OffchainLabs:master May 17, 2024
10 checks passed
@ImJeremyHe ImJeremyHe deleted the patch-2 branch May 17, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ImJeremyHe @tsahee @joshuacolvin0