From 3abce8775b1862abadca076d9c4b3f1b9d83abca Mon Sep 17 00:00:00 2001 From: Lee Bousfield Date: Tue, 9 Apr 2024 10:44:07 -0500 Subject: [PATCH] Fix data poster noop storage check in batch poster --- arbnode/batch_poster.go | 2 +- arbnode/dataposter/data_poster.go | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/arbnode/batch_poster.go b/arbnode/batch_poster.go index 32b6175108..ec4907688d 100644 --- a/arbnode/batch_poster.go +++ b/arbnode/batch_poster.go @@ -491,7 +491,7 @@ func (b *BatchPoster) checkReverts(ctx context.Context, to int64) (bool, error) return false, fmt.Errorf("getting a receipt for transaction: %v, %w", tx.Hash, err) } if r.Status == types.ReceiptStatusFailed { - shouldHalt := !b.config().DataPoster.UseNoOpStorage + shouldHalt := !b.dataPoster.UsingNoOpStorage() logLevel := log.Warn if shouldHalt { logLevel = log.Error diff --git a/arbnode/dataposter/data_poster.go b/arbnode/dataposter/data_poster.go index 416ebf7253..96fbe96275 100644 --- a/arbnode/dataposter/data_poster.go +++ b/arbnode/dataposter/data_poster.go @@ -304,6 +304,10 @@ func (p *DataPoster) MaxMempoolTransactions() uint64 { return arbmath.MinInt(config.MaxMempoolTransactions, config.MaxMempoolWeight) } +func (p *DataPoster) UsingNoOpStorage() bool { + return p.usingNoOpStorage +} + var ErrExceedsMaxMempoolSize = errors.New("posting this transaction will exceed max mempool size") // Does basic check whether posting transaction with specified nonce would