From ba66b82c3272ed5fba7151547c6c601b47a16bcc Mon Sep 17 00:00:00 2001 From: Lee Bousfield Date: Fri, 15 Dec 2023 15:24:59 -0700 Subject: [PATCH 1/2] Ensure sequencer backlog is populated before any clients connect --- arbnode/node.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arbnode/node.go b/arbnode/node.go index f2ed2941fa..8be2a982cf 100644 --- a/arbnode/node.go +++ b/arbnode/node.go @@ -773,9 +773,9 @@ func (n *Node) Start(ctx context.Context) error { return fmt.Errorf("error initializing feed broadcast server: %w", err) } } - if n.InboxTracker != nil && n.BroadcastServer != nil && config.Sequencer && !config.SeqCoordinator.Enable { - // Normally, the sequencer would populate the feed backlog when it acquires the lockout. - // However, if the sequencer coordinator is not enabled, we must populate the backlog on startup. + if n.InboxTracker != nil && n.BroadcastServer != nil && config.Sequencer { + // Even if the sequencer coordinator will populate this backlog, + // we want to make sure it's populated before any clients connect. err = n.InboxTracker.PopulateFeedBacklog(n.BroadcastServer) if err != nil { return fmt.Errorf("error populating feed backlog on startup: %w", err) From f76ba8e8aca952fc7f4dba597c904410f699d8ce Mon Sep 17 00:00:00 2001 From: Lee Bousfield Date: Fri, 15 Dec 2023 16:10:07 -0700 Subject: [PATCH 2/2] Ensure confirmed sequence number metric is populated --- broadcaster/backlog/backlog.go | 1 + 1 file changed, 1 insertion(+) diff --git a/broadcaster/backlog/backlog.go b/broadcaster/backlog/backlog.go index 448bb79b13..851561f482 100644 --- a/broadcaster/backlog/backlog.go +++ b/broadcaster/backlog/backlog.go @@ -69,6 +69,7 @@ func (b *backlog) Append(bm *m.BroadcastMessage) error { segment = newBacklogSegment() b.head.Store(segment) b.tail.Store(segment) + confirmedSequenceNumberGauge.Update(int64(msg.SequenceNumber)) } prevMsgIdx := segment.End()