From bd0ea0501db438d4f32c1f7b5f11ac8ce365175f Mon Sep 17 00:00:00 2001 From: a-thomas-22 Date: Wed, 28 Aug 2024 22:06:09 -0500 Subject: [PATCH 1/4] Remove rollingupdate data from updatestrategy nitro chart is not able to be configured to use updateStrategy.type: OnDelete a. the base values.yaml sets updateStrategy.rollingUpdate.partition: 0, this causes deploys to error because OnDelete cannot support the rollingUpdatekey b. we are currently using pulumi to deploy the helm charts, and pulumi has an issue piping null values to charts. otherwise i could use this to nullify the rollingUpdate config. c. updateStrategy.rollingUpdate.partition already defaults to 0 for statefulsets, so a fix here could be not explicitly setting rollingUpdate in values.yaml --- charts/nitro/Chart.yaml | 2 +- charts/nitro/values.yaml | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/charts/nitro/Chart.yaml b/charts/nitro/Chart.yaml index 3bff7ea..e0435ea 100644 --- a/charts/nitro/Chart.yaml +++ b/charts/nitro/Chart.yaml @@ -7,6 +7,6 @@ maintainers: type: application -version: 0.6.11 +version: 0.6.12 appVersion: "v3.1.0-7d1d84c" diff --git a/charts/nitro/values.yaml b/charts/nitro/values.yaml index d7be1b6..effacfc 100644 --- a/charts/nitro/values.yaml +++ b/charts/nitro/values.yaml @@ -40,11 +40,8 @@ startupProbe: command: "" ## @param updateStrategy.type Update strategy type -## @param updateStrategy.rollingUpdate.partition Partition to update updateStrategy: type: RollingUpdate - rollingUpdate: - partition: 0 ## @param persistence.enabled Enable persistence ## @param persistence.size Size of the persistent volume claim From 80a32135085d5fa574ed60d942e47d14dcba645a Mon Sep 17 00:00:00 2001 From: a-thomas-22 Date: Thu, 29 Aug 2024 03:06:42 +0000 Subject: [PATCH 2/4] Update README and values.schema.json for modified charts --- charts/nitro/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/charts/nitro/README.md b/charts/nitro/README.md index 7897042..df312cd 100644 --- a/charts/nitro/README.md +++ b/charts/nitro/README.md @@ -90,7 +90,6 @@ helm install xai offchainlabs/nitro -f values.yaml | `startupProbe.periodSeconds` | Number of seconds between startup probes | `1` | | `startupProbe.command` | Command to run for the startup probe. If empty, the built in probe will be used | `""` | | `updateStrategy.type` | Update strategy type | `RollingUpdate` | -| `updateStrategy.rollingUpdate.partition` | Partition to update | `0` | | `persistence.enabled` | Enable persistence | `true` | | `persistence.size` | Size of the persistent volume claim | `500Gi` | | `persistence.storageClassName` | Storage class of the persistent volume claim | `nil` | From 2331c02acea1d56f20426937b125170f7ba233f1 Mon Sep 17 00:00:00 2001 From: a-thomas-22 Date: Wed, 28 Aug 2024 22:07:09 -0500 Subject: [PATCH 3/4] Trigger CI From 15c264db67a05c2b65ccfefcb9f1fd8b284b0c5d Mon Sep 17 00:00:00 2001 From: a-thomas-22 Date: Thu, 29 Aug 2024 08:35:27 -0500 Subject: [PATCH 4/4] Update Chart.yaml --- charts/nitro/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/nitro/Chart.yaml b/charts/nitro/Chart.yaml index e0435ea..94dbd99 100644 --- a/charts/nitro/Chart.yaml +++ b/charts/nitro/Chart.yaml @@ -7,6 +7,6 @@ maintainers: type: application -version: 0.6.12 +version: 0.6.14 appVersion: "v3.1.0-7d1d84c"