From 78efaf2261a82b809fb22374944020f8735d58b7 Mon Sep 17 00:00:00 2001
From: Alec Thomas <112640918+a-thomas-22@users.noreply.github.com>
Date: Thu, 19 Dec 2024 10:35:55 -0600
Subject: [PATCH] Remove upgrade CI check (#92)

Fails and is not useful for our charts.
---
 .github/workflows/test-upgrade.yaml | 77 -----------------------------
 scripts/helm-wrapper.sh             | 10 ----
 2 files changed, 87 deletions(-)
 delete mode 100644 .github/workflows/test-upgrade.yaml
 delete mode 100755 scripts/helm-wrapper.sh

diff --git a/.github/workflows/test-upgrade.yaml b/.github/workflows/test-upgrade.yaml
deleted file mode 100644
index 8115360..0000000
--- a/.github/workflows/test-upgrade.yaml
+++ /dev/null
@@ -1,77 +0,0 @@
-name: Test Charts (Upgrade)
-
-on:
-  pull_request:
-    branches:
-      - main
-
-jobs:
-  test-upgrade:
-    runs-on: ubuntu-8
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      - name: Set up Helm
-        uses: azure/setup-helm@v3
-        with:
-          version: v3.14.0
-
-      - name: Set up chart-testing
-        uses: helm/chart-testing-action@v2.6.1
-
-      - name: Create kind cluster
-        uses: helm/kind-action@v1.9.0
-
-      - name: Run chart-testing (list-changed)
-        id: list-changed
-        run: |
-          changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }} --config ct.yaml)
-          if [[ -n "$changed" ]]; then
-            echo "changed=true" >> "$GITHUB_OUTPUT"
-          fi
-
-      - name: Prepare CI secrets for Helm as a single quoted string
-        if: steps.list-changed.outputs.changed == 'true'
-        env:
-          CI_TEST_ACCOUNT_PRIVATE_KEY: ${{ secrets.CI_TEST_ACCOUNT_PRIVATE_KEY }}
-          CI_PARENT_CHAIN_URL_SEPOLIA: ${{ secrets.CI_PARENT_CHAIN_URL_SEPOLIA }}
-          CI_BASELINE_RPC_KEY_SEPOLIA: ${{ secrets.CI_BASELINE_RPC_KEY_SEPOLIA }}
-          CI_PARENT_CHAIN_BLOB_CLIENT_URL: ${{ secrets.CI_PARENT_CHAIN_BLOB_CLIENT_URL }}
-          # Map additional secrets as needed
-        run: |
-          secrets_for_helm=""
-          # Capture all 'CI_' prefixed environment variables into an array
-          IFS=$'\n' read -r -d '' -a secret_names < <(env | grep '^CI_' | sed 's/=.*//' && printf '\0')
-          
-          for secret_name in "${secret_names[@]}"; do
-            # Extract the variable name without the CI_ prefix for Helm values
-            variable_name=$(echo $secret_name | sed 's/^CI_//')
-            # Get the value of the dynamic variable name
-            secret_value=${!secret_name}
-            # Append to the secrets string in the required format
-            if [ -z "$secrets_for_helm" ]; then
-              secrets_for_helm="ci.secrets.${variable_name}=${secret_value}"
-            else
-              secrets_for_helm="${secrets_for_helm},ci.secrets.${variable_name}=${secret_value}"
-            fi
-          done
-          
-          # Remove the initial comma to clean up the formatct
-          secrets_for_helm=${secrets_for_helm#,}
-          
-          # Format the entire string for --helm-extra-set-args, ensuring it's properly quoted
-          helm_extra_set_args="--set ${secrets_for_helm}"
-
-          # Use the command directly or set the HELM_EXTRA_SET_ARGS environment variable for later use in the workflow
-          echo "HELM_EXTRA_SET_ARGS=${helm_extra_set_args}" >> $GITHUB_ENV
-        
-        
-      - name: Run chart-testing (upgrade)
-        if: steps.list-changed.outputs.changed == 'true'
-        run: |
-          export PATH=$GITHUB_WORKSPACE/scripts:$PATH
-          ct install --target-branch ${{ github.event.repository.default_branch }} --config ct.yaml --upgrade --helm-extra-set-args "$HELM_EXTRA_SET_ARGS"
diff --git a/scripts/helm-wrapper.sh b/scripts/helm-wrapper.sh
deleted file mode 100755
index 5f09f98..0000000
--- a/scripts/helm-wrapper.sh
+++ /dev/null
@@ -1,10 +0,0 @@
-#!/bin/bash
-# This script is used as a stub for helm to substitute --reset-then-reuse-values
-# for instances of --reuse-values until https://github.com/helm/chart-testing/pull/531
-# or a similar PR is merged and released
-
-# Get the directory of the original helm binary
-helm_dir=$(dirname "$(which helm)")
-
-# Call the original helm binary with modified arguments
-exec "$helm_dir/helm" "${@//--reuse-values/--reset-then-reuse-values}"