-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CreateProject.ps1 #147
Open
donnybell
wants to merge
20
commits into
master
Choose a base branch
from
donnybell-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated with: - Prompted parameters - Informational Try/Catch - Existing Project name awareness
Updated with: - Prompted parameters - Informational Try/Catch - Current Project enabled/disabled status awareness
Updated with: - Prompted parameters - Informational Try/Catch - Confirmation before Project deletion when prompts are enabled
Updated with: - Prompted parameters - Informational Try/Catch - Existing Project name awareness - Slug support - Special character detection and optional removal
fixed tabs/spaces
fixed tabs/spaces
…rDeleteProjectsWithoutDeploymentProcess.ps1 Added various functions and precautions including: - Prompted parameters - Breaking out Projects without a Deployment Process into categories - Ability to output the list of affected Projects to a text file - Can look at "All" Spaces or a single SpaceId
Added comments
Added comments
Updated prompting to be the default option
Comment on lines
80
to
82
Write-Warning "A Project with the name `"$($ProjectName)`" already exists in `"$($SpaceId)`". Please choose a Project Name that does not exist in this Space." | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including more detailed exceptions for other possibilities could be a good improvement, to save someone scratching their head at why a server error returned a message saying a project already exists.
Catch {
$exception = $_.Exception
if($exception.Message.Contains("404") -or $exception.Message.Contains("403")){
write-host "Request failed with the following message: $($exception.Message)"
}else{
Write-Warning "A Project with the name `"$($ProjectName)`" already exists in `"$($SpaceId)`". Please choose a Project Name that does not exist in this Space."
}
}
Changed logic for committing the JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated with: