Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables in Helm values files are not parsed correctly #9140

Open
eddymoulton opened this issue Nov 22, 2024 · 0 comments
Open

Variables in Helm values files are not parsed correctly #9140

eddymoulton opened this issue Nov 22, 2024 · 0 comments
Labels
kind/bug This issue represents a verified problem we are committed to solving

Comments

@eddymoulton
Copy link

Severity

No response

Version

Latest (2025.1.1396)

Latest Version

I could reproduce the problem in the latest build

What happened?

Reported by customers via community slack: https://octopususergroup.slack.com/archives/C6UGLUWMQ/p1731303503059749

Thomas Bereczky Nov 11th at 4:38 PM

Hey Folks,
I got stuck a bit, we got over 20 helm charts where we are doing everything always the same, now there is one pesky helm chart that is causing a huge headache with the values.yaml.
https://gyazo.com/11ce5f6af8eab2b084a12ae038690d1d
Did anyone meet this issue before? Is there any chance I could connect with someone from support for a call? (edited)
https://gyazo.com/11ce5f6af8eab2b084a12ae038690d1d

Finnian Dempsey Nov 12th at 11:10 AM

I believe "ParseTemplateValuesFilesFromDependencies" implies the values is coming from a file so it sounds like the values file being loaded from a package is mis-formed:
image

Thomas Bereczky Nov 12th at 12:02 PM

I figured it out, so basically I had a variable which contained a JSON array: ["SOMETHING"]
🙌

and basically it could not skip the quotes
my work around was to hardcode the variable in the code 😄
...
I tried but I ended up hardcoding it into the code, since we did not even use that variable it did not matter for us

Siim Viikman Saturday at 2:28 AM

I had the same problem. In the end it seemed to be issue when yaml contained json non-compliant keys with dash (like min-replicas-to-write).
But it only occurred when I had my inline YAML defined as this:
#{Service.HelmYaml}
and Service.HelmYaml contained configuration like this:

replicas: 3
config:
  min-replicas-to-write: 1

When I replaced my inline yaml directly with variable value, it worked.
I think it is kind of a bug, as many public helm templates (which I don't have control over) contain such values... (edited)

Reproduction

Reprodution: OctopusDeploy/Calamari#1390

Error and Stacktrace

No response

More Information

No response

Workaround

Current workaround is to not use variables when setting helm values.

@eddymoulton eddymoulton added the kind/bug This issue represents a verified problem we are committed to solving label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

1 participant