Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid deployment process can be submitted via API, this is not possible using the UI. #6712

Open
5 tasks done
octocrock opened this issue Dec 18, 2020 · 2 comments
Open
5 tasks done
Labels
area/core kind/bug This issue represents a verified problem we are committed to solving

Comments

@octocrock
Copy link

Are you a customer of Octopus Deploy? Don't raise the issue here. Please contact our support team so we can triage your issue, making sure it's handled appropriately.

Prerequisites

  • I have verified the problem exists in the latest version
  • I have searched open and closed issues to make sure it isn't already reported
  • I have written a descriptive issue title
  • I have linked the original source of this report
  • I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

It's possible to use the API to submit a deployment process that is invalid, causing unexpected behaviour. The UI stops this deployment process being created.

Process is invalid because:

  • It's got child steps and the parent step does not have a target role assigned.
  • The parent step is a manual intervention step that cannot have a target role associated as it runs on the Octopus server, therefore it can't be a parent step.

What I expected to happen

The validation should match that in the UI.

Steps to reproduce

This API request reproduces the issue:
curl_manualintervention.txt

The invalid deployment process looks like:
image (34)

Log excerpt

Insert your log excerpt here.

Affected versions

Tested on 2020.5.2

Octopus Server:

Workarounds

This does not prevent the customer working.

Links

https://octopus.zendesk.com/agent/tickets/62229

@octocrock octocrock added the kind/bug This issue represents a verified problem we are committed to solving label Dec 18, 2020
@mcasperson mcasperson added the product/noqrfcapacity Do not use this label anymore label Dec 21, 2020
@mcasperson
Copy link

We have flagged this as an issue with product, but at this point we do not have capacity to assign an engineer to resolve the issue. We'll keep the issue open, but unfortunately we can not provide any guidance as to when it will be resolved.

@mcasperson
Copy link

mcasperson commented Dec 21, 2020

Internal link to QRF card

@kengel100 kengel100 added area/core and removed product/noqrfcapacity Do not use this label anymore labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

3 participants