You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since the CancellationToken is not passed, if an RPC call is cancelled the cancellation of the cancellation token wont result in the write being cancelled resulting in Halibut taking longer to cancel the call.
This can be worked around by using one of the other DataStream constructor methods.
Note that stream timeouts still apply, so Halibut can not be stuck forever in the write.
The issue is in the code below.
The text was updated successfully, but these errors were encountered:
LukeButters
changed the title
DataStream.FromString does not pass the cancellation token, meaning we wont respect cancelled API calls.
DataStream.FromString does not pass the cancellation token, meaning we wont respect cancelled RPC calls.
Dec 18, 2023
Since the CancellationToken is not passed, if an RPC call is cancelled the cancellation of the cancellation token wont result in the write being cancelled resulting in Halibut taking longer to cancel the call.
This can be worked around by using one of the other DataStream constructor methods.
Note that stream timeouts still apply, so Halibut can not be stuck forever in the write.
The issue is in the code below.
The text was updated successfully, but these errors were encountered: