Nullable values types should be considered a match for null arguments

OctopusDeploy · May 2, 2024 · bae83b2 · bae83b2
1 parent f97f7e9
commit bae83b2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/source/Halibut/Portability/TypeExtensions.cs b/source/Halibut/Portability/TypeExtensions.cs
@@ -17,5 +17,10 @@ public static bool IsValueType(this Type type)
         {
             return type.IsValueType;
         }
+
+        public static bool IsNullable(this Type type)
+        {
+            return !type.IsValueType() || Nullable.GetUnderlyingType(type) != null;
+        }
     }
 }
diff --git a/source/Halibut/ServiceModel/ServiceInvoker.cs b/source/Halibut/ServiceModel/ServiceInvoker.cs
@@ -68,7 +68,7 @@ static MethodInfo SelectAsyncMethod(IList<MethodInfo> methods, RequestMessage re
                 {
                     var paramType = parameters[i].ParameterType;
                     var argType = argumentTypes[i];
-                    if (argType == null && paramType.IsValueType())
+                    if (argType == null && !paramType.IsNullable())
                     {
                         isMatch = false;
                         break;