Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature toggle to disable FSharp script execution #1411

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

APErebus
Copy link
Contributor

In discussion with @zentron, we missed adding the "soft" disable of FSharp scripts in 2024.3, so adding this here via a feature toggle DisableFSharpScriptExecutionFeatureToggle

Just throws a CommandExecption when feature toggle is enabled

@APErebus APErebus requested a review from zentron December 13, 2024 00:50
Copy link
Contributor

@zentron zentron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick and simple. If we have a link somewhere i'd add that as well. But otherwise :shipit:

@APErebus
Copy link
Contributor Author

APErebus commented Dec 13, 2024

Quick and simple. If we have a link somewhere i'd add that as well. But otherwise :shipit:

Just a link to the deprecation notice?

Adde a link to the deprecation notice in the error

@APErebus APErebus enabled auto-merge (squash) December 13, 2024 01:26
@APErebus APErebus merged commit 2684d90 into release/28.2.0 Dec 13, 2024
41 checks passed
@APErebus APErebus deleted the ap/hotfix-disable-fsharp branch December 13, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants